Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowableValues expects an array to map to enum #6739

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

Himpoke
Copy link
Contributor

@Himpoke Himpoke commented Oct 28, 2024

In swagger.json generation, under 'components.schemas.Broadcasts', a number of enums are defined.
They are defined as having a single value, consisting of a comma separated list of the actual values.
By correctly defining the values as a list of values, this enum export will also result in a list of values.

Currently, when we want to do code generation from this swagger file, we have to actually edit the file received from ant media, making the build process a lot harder than it needs to be.

          "status": {
            "type": "string",
            "description": "the status of the stream",
            "enum": [
              "finished,broadcasting,created,preparing,error,failed"
            ]
          },
          "playListStatus": {
            "type": "string",
            "description": "The status of the playlist. It's usable if type is playlist",
            "enum": [
              "finished,broadcasting,created,preparing,error,failed"
            ]
          },
          "type": {
            "type": "string",
            "description": "the type of the stream",
            "enum": [
              "liveStream,ipCamera,streamSource,VoD,playlist"
            ]
          },
          "publishType": {
            "type": "string",
            "description": "The publish type of the stream. It's read-only and its value updated on the server side",
            "enum": [
              "WebRTC,RTMP,Pull"
            ]
          },

@mekya
Copy link
Contributor

mekya commented Nov 5, 2024

Thank you for the fix @Himpoke .

I need to create another branch because github does not allow get some security variables for the PRs coming repos

It will be merged through this PR
#6767

Thank you

@Himpoke
Copy link
Contributor Author

Himpoke commented Nov 5, 2024

You're welcome, I'm very happy this got picked up so quickly.

@mekya mekya merged commit e8fa574 into ant-media:master Nov 6, 2024
9 of 12 checks passed
@mekya
Copy link
Contributor

mekya commented Nov 6, 2024

It's our pleasure. I want to invite you to our community event next week. I want to hear your suggestions/feedback.

Here is the Agenda
https://antmedia.io/join-webinar-for-3-new-live-demos-e-rtmp-low-latency-hls-free-viewpoint-video/

Let me know your email address and I can invite you directly. You can text your email to me onlinkedin

Alternatively, add to your calendar
https://calendar.google.com/calendar/event?action=TEMPLATE&tmeid=NDAzbnRtdjNqbjJoaTdnb3I2dDQzODcycGIgbWVreWFAYW50bWVkaWEuaW8&tmsrc=mekya%40antmedia.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants