Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split RTMP StreamId by slash(/) to parse Token and TOTP #6709

Merged
merged 8 commits into from
Nov 3, 2024
Merged

Split RTMP StreamId by slash(/) to parse Token and TOTP #6709

merged 8 commits into from
Nov 3, 2024

Conversation

lastpeony
Copy link
Contributor

@lastpeony lastpeony commented Oct 7, 2024 •
edited by mekya
Loading

@lastpeony
Copy link
Contributor Author

https://gitlab.com/Ant-Media/Ant-Media-Enterprise/-/merge_requests/736

@lastpeony lastpeony requested a review from mekya October 8, 2024 09:01
@mekya mekya changed the title Parse Rtmp Url Segment Params Parse Rtmp URL Segment Params Nov 3, 2024
mekya
mekya approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feature @lastpeony 👏

@mekya
Copy link
Contributor

mekya commented Nov 3, 2024

#6704

With this PR this is valid:

rtmp://localhost/LiveApp/testStream/mtoken/msubscriberId/msubscriberCode

image

For ffmpeg RTMP publish this should be used:

rtmp://localhost/LiveApp/testStream%2Fmy_token%2Fm_subscriberId%2Fm_subscriberCode

because ffmpeg gets after last index of /

It's unlikely that anyone would use this over query parameters in FFmpeg, but it can still be useful for integration testing.

Server will handle both cases.

@mekya mekya changed the title Parse Rtmp URL Segment Params Parse Rtmp URL Segment Params For Token and TOTP Nov 3, 2024
@mekya mekya changed the title Parse Rtmp URL Segment Params For Token and TOTP Segment RTMP URL by slash(/) to Parse Token and TOTP Nov 3, 2024
@mekya mekya changed the title Segment RTMP URL by slash(/) to Parse Token and TOTP Segment RTMP URL by slash(/) to parse Token and TOTP Nov 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 3, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mekya mekya changed the title Segment RTMP URL by slash(/) to parse Token and TOTP Split RTMP StreamId by slash(/) to parse Token and TOTP Nov 3, 2024
@mekya mekya merged commit c6eb3a3 into master Nov 3, 2024
9 checks passed
@mekya mekya deleted the rtmpParseUrlSegmentParams branch November 3, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekya mekya mekya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lastpeony @mekya