Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: High-cardinality metrics and updates to middleware #221

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: High-cardinality metrics and updates to middleware #221

wants to merge 2 commits into from
+404 −199

Conversation

gaby
Copy link
Contributor

@gaby gaby commented Nov 4, 2024

  • Fix issues with high-cardinality metrics
  • Remove cache metrics since they don't work. This was confirmed with the Fiber team.
  • Bump min go to 1.22
  • Update GitHub Workflows
  • Update dependencies
  • Add NewWithDefaultRegistry that creates a new instance using the default prometheus.DefaultRegisterer
  • Added unit-test for duplicated registration
  • Added unit-test for gauge
  • Expanded current unit-tests
  • Optimized the check for skipPaths by using a map of booleans.

Fixes #209
Fixes #215
Closes #219
Closes #220

@gaby gaby mentioned this pull request Nov 4, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansrivas ansrivas ansrivas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not collect custom metrics ctx.Request().RequestURI() leads to high cardinality metric
2 participants
@gaby @ansrivas