-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable explanation thumbs up and thumbs down buttons after selection #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabashian
force-pushed
the
mabashian/aap-34644-disable-thumb-buttons
branch
from
December 6, 2024 20:09
444bbd4
to
15b555c
Compare
manstis
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Sweet.
mabashian
force-pushed
the
mabashian/aap-34644-disable-thumb-buttons
branch
from
December 9, 2024 18:11
15b555c
to
752ecd9
Compare
mabashian
force-pushed
the
mabashian/aap-34644-disable-thumb-buttons
branch
from
December 9, 2024 20:30
752ecd9
to
fd20920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ask here was to disable the thumbs up and thumbs down buttons after a user interacts with one of them in the playbook explanation panel. Inside the same function(s) that update the button class, I went ahead and set the
disabled
attribute which the button component seems to handle correctly.