Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable explanation thumbs up and thumbs down buttons after selection #1715

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

mabashian
Copy link
Member

The ask here was to disable the thumbs up and thumbs down buttons after a user interacts with one of them in the playbook explanation panel. Inside the same function(s) that update the button class, I went ahead and set the disabled attribute which the button component seems to handle correctly.

disabled_thumbs_up_down

@mabashian mabashian requested review from a team as code owners December 6, 2024 20:06
@mabashian mabashian force-pushed the mabashian/aap-34644-disable-thumb-buttons branch from 444bbd4 to 15b555c Compare December 6, 2024 20:09
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Sweet.

@mabashian mabashian merged commit 8eedb08 into main Dec 9, 2024
15 checks passed
@mabashian mabashian deleted the mabashian/aap-34644-disable-thumb-buttons branch December 9, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants