Add HMAC verification support to webhook plugin #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Izquierdo
previously approved these changes
Aug 8, 2023
|
@Alex-Izquierdo Thank you! |
|
Hi, I've merged the main branch and fixed the new tox issues. |
|
@Alex-Izquierdo No problem, I'll revert the changes made in 7d65d2d after #167 merged into main. This PR will be up-to-date with the main branch, if that's OK for you. |
|
sure, thank you very much. @lszomor |
Alex-Izquierdo
approved these changes
Aug 31, 2023
bzwei
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HMAC verification support for webhook plugin.
Rationale
For security reasons, payloads originating from services supporting HMAC signatures, such as GitHub, Bitbucket, and Dropbox, should be verifiable.
Implementation details
The current implementation supports hex and base64 signature formats.
The argument defaults are aligned with GitHub defaults.
The HMAC verification can be used in addition to the existing Bearer token validation.