Skip to content

Commit

Permalink
Fix i18n issue (#1216) (#1218)
Browse files Browse the repository at this point in the history
* Fixing the test to prove translatedable strings are correct in prod

* Fixes https://issues.redhat.com/browse/AAH-982

Extract and compile new translatable strings to prevent wrong display in prod that looks like "string{0}string"

(cherry picked from commit 8b34c28)

Co-authored-by: ZitaNemeckova <[email protected]>
  • Loading branch information
patchback[bot] and ZitaNemeckova authored Nov 8, 2021
1 parent ce1c164 commit 5f9dbe2
Show file tree
Hide file tree
Showing 13 changed files with 5,318 additions and 2,663 deletions.
2 changes: 1 addition & 1 deletion locale/en.js

Large diffs are not rendered by default.

1,802 changes: 1,306 additions & 496 deletions locale/en.po

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion locale/es.js

Large diffs are not rendered by default.

1,784 changes: 1,296 additions & 488 deletions locale/es.po

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion locale/fr.js

Large diffs are not rendered by default.

865 changes: 471 additions & 394 deletions locale/fr.po

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion locale/ja.js

Large diffs are not rendered by default.

865 changes: 471 additions & 394 deletions locale/ja.po

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion locale/nl.js

Large diffs are not rendered by default.

1,784 changes: 1,296 additions & 488 deletions locale/nl.po

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion locale/zh.js

Large diffs are not rendered by default.

865 changes: 471 additions & 394 deletions locale/zh.po

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions test/cypress/support/commands.js
Original file line number Diff line number Diff line change
Expand Up @@ -604,9 +604,7 @@ Cypress.Commands.add('syncRemoteContainer', {}, (name) => {
.parents('tr')
.contains('.pf-c-dropdown__menu-item', 'Sync from registry')
.click();

// FIXME: `Sync initiated for ${name}` after AAH-972 is fixed (shows `Sync initiated for {name}` on GH)
cy.contains('.pf-c-alert__title', `Sync initiated for`);
cy.contains('.pf-c-alert__title', `Sync initiated for ${name}`);
});

Cypress.Commands.add('deleteRegistries', {}, () => {
Expand Down

0 comments on commit 5f9dbe2

Please sign in to comment.