SNMP model

[aida-shumburo]

No description provided.

[kerry-meyer]

I am posting several comments requesting some minor changes, but this model is structured correctly and is a suitable base for starting the "module" implementation.

[kerry-meyer]

I checked the PR content with the most recent changes. Some of my previously posted "Issues" have been resolved with the changes. But there are some remaining issues. I have posted additional information to explain these issues.

[kerry-meyer]

I am posting some requests for changes in the "Examples" files.

After these changes are made, we can proceed with a request to get this model merged.

[ArunSaravananBalachandran]

In the example files, please ensure that the sample playbook is not commented out.

[kerry-meyer]

I am posting some additional comments requesting changes.

I have checked the changes made for my previous set of comments on the "Examples" section. The requested changes go most of the way toward addressing the comments, but there are still a few related corrections to make. Also, in checking the changes, I realized that an additional change is needed in the model (.yaml) file to correctly represent the mutually exclusive nature of user "priv" key types. (This is very similar to the problem already addressed for user "auth" key types.)

[kerry-meyer]

The latest revisions correctly address the previous set of change requests. I am requesting only two very minor additional adjustments to the descriptive comments.

[kerry-meyer]

As with the "auth_type" option, please add a "choices" attribute here instead of only stating it in the description. This will eliminate the need to check this in the executable code.

(The description part for the choices is optional if an explicit "choices" attribute is used.)

[kerry-meyer]

Please clarify that the maximum scope of deletion is a single top level sub-option.

Suggested change

	- name: Delete all SNMP server configuration
	- name: Delete all SNMP server configuration for the "user" sub-option.