feat(text randomizer): implement text randomizer and toggle between wheel #14

imballinst · 2021-11-18T14:54:05Z

Closes #10. This PR contains:

Implementation to text randomizer component: TextBlinkRandomizer
Implementation to tabs to toggle between wheel and text randomizer
Slight tweak to fetching order: instead of fetching at the end, we fetch as the randomizer starts, so that there will be no delay after the choice is picked

Signed-off-by: Try Ajitiono <[email protected]>

vercel · 2021-11-18T14:54:10Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ans4175/random-gofood/9sj5fCsT2sSPyvngsK5H582VQLPM
✅ Preview: https://random-gofood-git-fork-imballinst-10-tabs-randomizer-ans4175.vercel.app

[Deployment for c8b8b9f failed]

imballinst · 2021-11-18T14:56:57Z

@ans-4175 ada ide ngga untuk ngedengerin event change di tabsnya? Tidak terlihat ada propsnya di docs ini: https://github.com/rough-stuff/wired-elements/blob/master/docs/wired-tabs.md#wiredtabs-properties

Terus saya entah kenapa dapet eror ini:

padahal di Codesandbox seperti aman: https://codesandbox.io/s/react-wrapper-for-wired-elements-forked-fef11?file=/src/index.js

ans-4175 · 2021-11-18T15:18:11Z

hf.fillPolygon

Ini kemarin aku kena isu ini di Roulette, bukan di wired element kalau tak salah.

ans-4175 · 2021-11-18T15:21:31Z

listen event tab

https://github.com/rough-stuff/wired-elements/blob/master/src/wired-tabs.ts
Disini dia ga ada fireEvent euy, emang dia ga ngebuang sesuatu, bagaimana kalau itu dipasang ref dan baca perubahan nilai property selected-nya di wiredTabs

src/App.js

imballinst · 2021-11-18T15:23:38Z

listen event tab

https://github.com/rough-stuff/wired-elements/blob/master/src/wired-tabs.ts Disini dia ga ada fireEvent euy, emang dia ga ngebuang sesuatu, bagaimana kalau itu dipasang ref dan baca perubahan nilai property selected-nya di wiredTabs

OK, ini bisa dicoba

ans-4175 · 2021-11-18T15:23:41Z

src/App.js

          <p>Loading merchants data...</p>
        ) : isError || posError ? (
          <p>Error: {isError ? error.message : posError.message}</p>
        ) : (
          <>
            <section>
-              {wheelData && (
-                <>
+              <WiredTabs selected="wheel">


nah ini coba dipasang property selected-nya kalau berubah gitu

o ternyata dia kalau hasil build dengan NODE_ENV=production ngga eror ya? Cuma di lokal aja erornya... menarik

error yang selected?
Aku belum nyambung

iyak, ini kalau di lokal aku, dia bakal ngecrash

tapi kalau di https://random-gofood-git-fork-imballinst-10-tabs-randomizer-ans4175.vercel.app/, dia nggak nge-crash, kenapa yak? padahal kodenya sama

kalau aku dulu, itu masalah si pas yarn start-nya, kl dijalanin ulang lagi tetap masalah?

iyak, dijalanin ulang tetep masalah. setelah saya liat lagi ternyata dia kalau di prod tetep ada erornya yang sama, tapi ngga bikin crash:

src/App.js

imballinst · 2021-11-18T15:29:57Z

@ans-4175 saya isi App.js cuma ini masih ngecrash:

import { WiredTabs, WiredTab } from 'wired-elements-react';

import './App.css';

function App() {
  return (
    <WiredTabs>
      <WiredTab name="Wheel">test</WiredTab>
      <WiredTab name="Text">test2</WiredTab>
    </WiredTabs>
  );
}

export default App;

saya coba nuke terus install ulang node_modules deh

imballinst · 2021-11-18T16:01:52Z

wah, kurang paham, saya download file Sandbox https://codesandbox.io/s/react-wrapper-for-wired-elements-forked-fef11?file=/src/index.js, install, lalu jalanin, tetep crash 😅 mungkin harus dibawa tidur dulu baru bisa jalan

@ans-4175 kalau sempat, boleh tolong coba jalanin PR ini di lokal nggak? atau download lalu jalanin Sandbox ☝️ di lokal? takutnya ada masalah dependency yang aneh-aneh kayak apollographql/apollo-link-state#187

imballinst · 2021-11-18T16:10:56Z

Oh, kayaknya ini penyebabnya: rough-stuff/rough@24fd61d#diff-054c66f0fb4838b0ff226ca4dea0ebcc007364ff1baf314d788a8015cbac108a

Dia ngeresolve packagenya ke package versi yang terbaru, yang mana fillPolygon udah berubah jadi fillPolygons. Mungkin kita bisa kasih resolutions di package.json sehingga dia selalu ngarah ke versi sebelumnya

EDIT: hore bisa

ans-4175 · 2021-11-18T16:16:59Z

Iyah aku coba di codespaces juga error

ans-4175 · 2021-11-18T16:17:31Z

Dia ngeresolve packagenya ke package versi yang terbaru

Oh oke, fixed?

imballinst · 2021-11-19T00:52:40Z

Dia ngeresolve packagenya ke package versi yang terbaru

Oh oke, fixed?

@ans-4175 iyak, fixed. Saya submit bugnya di rough-stuff/wired-elements#179. Nanti saya follow-up di sini pakai Yarn module resolutions ke "roughjs": "4.4" untuk sementara waktu.

Signed-off-by: Try Ajitiono <[email protected]>

imballinst · 2021-11-19T12:58:54Z

@ans-4175 saya boleh pake https://www.npmjs.com/package/patch-package aja nggak? Kayaknya lebih straightforward daripada kalau harus nambahin ref lalu listen childrennya... mungkin kalau mau nanti patchnya bisa dikontribusiin juga ke wired-elements dan wired-elements-react

wired-elements-react

diff --git a/node_modules/wired-elements-react/lib/WiredTabs.d.ts b/node_modules/wired-elements-react/lib/WiredTabs.d.ts
index cbafd3d..c37934b 100644
--- a/node_modules/wired-elements-react/lib/WiredTabs.d.ts
+++ b/node_modules/wired-elements-react/lib/WiredTabs.d.ts
@@ -1,5 +1,7 @@
 import * as React from 'react';
 import { WiredTabs as CE } from 'wired-elements/lib/wired-tabs.js';
-export declare const WiredTabs: React.ForwardRefExoticComponent<Partial<CE> & {} & {
+export declare const WiredTabs: React.ForwardRefExoticComponent<Partial<CE> & {
+    onselected?: ((e: Event) => unknown) | undefined;
+} & {
     children?: React.ReactNode;
 } & React.RefAttributes<unknown>>;
diff --git a/node_modules/wired-elements-react/lib/WiredTabs.js b/node_modules/wired-elements-react/lib/WiredTabs.js
index 6c93459..461610a 100644
--- a/node_modules/wired-elements-react/lib/WiredTabs.js
+++ b/node_modules/wired-elements-react/lib/WiredTabs.js
@@ -1,4 +1,6 @@
 import * as React from 'react';
 import { createComponent } from '@lit-labs/react';
 import { WiredTabs as CE } from 'wired-elements/lib/wired-tabs.js';
-export const WiredTabs = createComponent(React, 'wired-tabs', CE);
+export const WiredTabs = createComponent(React, 'wired-tabs', CE, {
+  onselected: 'selected'
+});

wired-elements

diff --git a/node_modules/wired-elements/lib/wired-lib.js b/node_modules/wired-elements/lib/wired-lib.js
index 5b1d153..9d3ec39 100644
--- a/node_modules/wired-elements/lib/wired-lib.js
+++ b/node_modules/wired-elements/lib/wired-lib.js
@@ -90,7 +90,7 @@ export function ellipse(parent, x, y, width, height, seed) {
 }
 export function hachureFill(points, seed) {
     const hf = new ZigZagFiller(fillHelper);
-    const ops = hf.fillPolygon(points, options(seed));
+    const ops = hf.fillPolygons([points], options(seed));
     return createPathNode(ops, null);
 }
 export function hachureEllipseFill(cx, cy, width, height, seed) {
diff --git a/node_modules/wired-elements/lib/wired-tabs.js b/node_modules/wired-elements/lib/wired-tabs.js
index f9dfb28..58c8def 100644
--- a/node_modules/wired-elements/lib/wired-tabs.js
+++ b/node_modules/wired-elements/lib/wired-tabs.js
@@ -7,7 +7,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
 var __metadata = (this && this.__metadata) || function (k, v) {
     if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
 };
-import { BaseCSS } from './wired-base';
+import { fireEvent, BaseCSS } from './wired-base';
 import { css, html, LitElement } from 'lit';
 import { customElement, property, query } from 'lit/decorators.js';
 let WiredTabs = class WiredTabs extends LitElement {
@@ -149,6 +149,7 @@ let WiredTabs = class WiredTabs extends LitElement {
                 index--;
             }
             this.selected = list[index].name || '';
+            this.fireSelected();
         }
     }
     selectNext() {
@@ -171,8 +172,12 @@ let WiredTabs = class WiredTabs extends LitElement {
                 index++;
             }
             this.selected = list[index].name || '';
+            this.fireSelected();
         }
     }
+    fireSelected() {
+        fireEvent(this, 'selected', { selected: this.selected });
+    }
 };
 __decorate([
     property({ type: String }),

ans-4175 · 2021-11-19T13:07:40Z

Aku belum pernah pakai Itu gimana ya? Possible aja ya

On Fri, 19 Nov 2021 at 19.59 Try Ajitiono ***@***.***> wrote: @ans-4175 <https://github.com/ans-4175> saya boleh pake https://www.npmjs.com/package/patch-package aja nggak? Kayaknya lebih straightforward daripada kalau harus nambahin ref lalu listen childrennya... mungkin kalau mau nanti patchnya bisa dikontribusiin juga ke wired-elements dan wired-elements-react — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6HIEFD3NZ3RQWK42U2LYLUMZCZRANCNFSM5IJ2CPUQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Ahmad Anshorimuslim Syuhada Data Engineer - Web Developer - Linux Enthusiast +6285224752182 - @ans4175 "trust me I'm [already] an engineer"

imballinst · 2021-11-19T13:08:22Z

@ans-4175 kira-kira bagusan mana? yang pertama atau yang kedua?

yang pertama yang bawaan, yang kedua yang saya tweak. kok saya ngerasanya ada "border" di sekitar wheel itu kurang cocok ya? soalnya dia udah di atas elemen wired anyway... apakah elemen wired di atas elemen wired itu design language yang masuk?

imballinst · 2021-11-19T13:10:21Z

Aku belum pernah pakai
Itu gimana ya?
Possible aja ya

@ans-4175 jadi kita nge-update node_modules, nanti si patch-package ini bakal nge-output diff dari file-file yang kita update. setiap kali kita pakai command yarn, dia bakal re-apply diff-diff tersebut, jadi hasilnya konsisten

ans-4175 · 2021-11-19T13:26:57Z

Kita ngunci di paketnya gitu ya terus bikin diff Boleh deh cobain Aku ga terlalu kebayang ji Anyway, iyah tanpa border lebih masuk pas kayaknya Itu pakai wired card buatnya? Kok aneh ya

On Fri, 19 Nov 2021 at 20.10 Try Ajitiono ***@***.***> wrote: Aku belum pernah pakai Itu gimana ya? Possible aja ya @ans-4175 <https://github.com/ans-4175> jadi kita nge-update node_modules, nanti si patch-package ini bakal nge-output diff dari file-file yang kita update. setiap kali kita pakai command yarn, dia bakal re-apply diff-diff tersebut, jadi hasilnya konsisten — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6HIEE3X4VH5P5CGIZRV3DUMZEETANCNFSM5IJ2CPUQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Ahmad Anshorimuslim Syuhada Data Engineer - Web Developer - Linux Enthusiast +6285224752182 - @ans4175 "trust me I'm [already] an engineer"

imballinst · 2021-11-19T13:29:49Z

Kita ngunci di paketnya gitu ya terus bikin diff
Boleh deh cobain
Aku ga terlalu kebayang ji

iyak, betul 💯

Anyway, iyah tanpa border lebih masuk pas kayaknya
Itu pakai wired card buatnya? Kok aneh ya

kayaknya si tabs ini di-desain untuk berada di "tempat kosong" (bukan di atas elemen wired)... soalnya bawaan dari WiredTabnya demikian, seperti di showcasenya

Signed-off-by: Try Ajitiono <[email protected]>

imballinst · 2021-11-19T14:15:59Z

patches/wired-elements+3.0.0-rc.6.patch

+    fireSelected() {
+        fireEvent(this, 'selected', { selected: this.selected });
+    }


@ans-4175 begini kurang lebih cara saya nambahin event emitter (?) di komponennya

okay, berarti nanti dibacanya di atasnya onselected sama seperti yang radio group button

iyak, betul

ans-4175 · 2021-11-20T01:12:40Z

Pas di randomize text, kalau ngerandom lagi dia lebih dahulu nampilin hasil dibanding randomnya beres. Ada logic yang kelewat?

ans-4175 · 2021-11-20T01:13:32Z

Dilihat-lihat, apakah mungkin tab-textnya di tengah ya?

ans-4175

Ada beberapa logic yang shown merchant detail ini, nampaknya callback react-nya ga pas cycle-nya

ans-4175 · 2021-11-20T01:15:44Z

package.json

@@ -20,7 +20,8 @@
    "build": "CI=false && react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject",
-    "prettify": "prettier --write src"
+    "prettify": "prettier --write src",
+    "postinstall": "patch-package"


hoo baru tahu begini, berarti ini auto jalan?

iyak, jadi urutannya:

yarn --> node_modules terinstall (raw) --> patch-package (apply diff dari patches yang ada)

ans-4175 · 2021-11-20T01:16:25Z

patches/wired-elements+3.0.0-rc.6.patch

@@ -0,0 +1,113 @@
+diff --git a/node_modules/wired-elements/lib/wired-lib.js b/node_modules/wired-elements/lib/wired-lib.js


cara bikinnya ini gimana ji? BIkin file perubahannya, terus di diff sendiri dan hasil diffnya masukkin sini?

naming filenya juga?

o ini ada caranya, maap, habis ini saya tambahin di READMEnya

ans-4175 · 2021-11-20T01:17:03Z

patches/wired-elements+3.0.0-rc.6.patch

+     }
+     draw(svg, s) {
+-        rectangle(svg, 2, 2, s[0] - 4, s[1] - 4, this.seed);
+        if (this.hasBorder) {


patches/wired-elements-react+0.1.5.patch

src/App.css

ans-4175 · 2021-11-20T01:22:39Z

src/App.js

-    setFetched(false);
-    setMustSpin(false);
-    refetch();
+    resetStates();


src/App.js

ans-4175 · 2021-11-20T01:23:46Z

src/App.js

                  <Wheel
-                    mustStartSpinning={mustSpin}
+                    mustStartSpinning={
+                      randomizerMode === 'wheel' && mustStartRandomizing


ans-4175 · 2021-11-20T01:25:15Z

src/App.js

-                  <p className="txt-resto text-center">{pickedMerchant.name}</p>
+              {detailMerchant !== undefined &&
+                pickedMerchant !== undefined &&
+                isMerchantDetailShown && (


coba cek logic isMerchantDetailShown ini keubah dimana ya? Jadi muncul duluan sebelum beres stop spin atau randomizer

ans-4175 · 2021-11-20T01:26:40Z

src/components/TextBlinkRandomizer.js

+        <div>{optionsList[0].option}</div>
+
+        <div className="randomizer-text-helper">
+          Press "Randomize" button below to start.


wkwk, anti pattern. Dia berharap ada tombol click di bawah di luar dari component ini

wkwkwk, bener juga sih... apa kalau gitu mending dibuat gini?

Tombol spin dan tombol reset jadi 1 komponen sendiri: SpinnerButtons

Bikin komponen baru: WheelRandomizer -- yang ngeimport SpinnerButtons

Import SpinnerButtons di TextBlinkRandomizer yang ada sekarang

Delete spinner buttons yang ada di App.js

Saya jadinya pakai pattern children, kira-kira gimana? Saya senangnya pattern ini karena kita nggak perlu nambahin prop sih:

// App.js. const spinnerButtons = mustStartRandomizing ? ( <p>Waiting to {randomizeText}...</p> ) : ( <div> <WiredButton elevation={2} onClick={handleSpinClick}> {randomizeText} </WiredButton> <WiredButton className="btn-reset" elevation={2} onClick={handleResetClick} > RE-LOAD </WiredButton> </div> ); <TextBlinkRandomizer onFinishRandomizing={onFinishRandomizing} mustStartRandomizing={ randomizerMode === 'text' && mustStartRandomizing } pickedMerchant={pickedMerchant} optionsList={optionsList} > {spinnerButtons} </TextBlinkRandomizer> // TextBlinkRandomizer.js. if (shownText === undefined) { return ( <> <div className="randomizer-text-container"> <div>{optionsList[0].option}</div> <div className="randomizer-text-helper"> Press "Randomize" button below to start. </div> </div> {children} </> ); }

oh nice ini, dia berarti selalu dibungkus sesuatu. sip, betul jadi ga ngerubah prop sebelumnya

imballinst · 2021-11-20T02:13:21Z

Pas di randomize text, kalau ngerandom lagi dia lebih dahulu nampilin hasil dibanding randomnya beres. Ada logic yang kelewat?

...wah, my bad, OK saya cek lagi

Dilihat-lihat, apakah mungkin tab-textnya di tengah ya?

o iya bener, karena semuanya tengah, kayaknya lebih tepat di tengah. saya cobain

Signed-off-by: Try Ajitiono <[email protected]>

ans-4175 · 2021-11-20T03:52:24Z

Gabisa deng, dia classnya itu random generated eh

On Sat, 20 Nov 2021 at 09.16 Try Ajitiono ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/App.css <#14 (comment)>: > @@ -11,7 +11,9 @@ wired-card { } section { - max-width: 400px; + /* Make this the same with the wheel's width. */ + /* That way, the wheel will be properly centered. */ + max-width: 445px; saya belum riset mendalam, tapi mungkin bisa sih override max-width style di class bhdLno — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6HIEB7QOU4RW4DX2KCF7LUM4AIRANCNFSM5IJ2CPUQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Ahmad Anshorimuslim Syuhada Data Engineer - Web Developer - Linux Enthusiast +6285224752182 - @ans4175 "trust me I'm [already] an engineer"

Signed-off-by: Try Ajitiono <[email protected]>

imballinst · 2021-11-20T04:36:44Z

oiya deng, dia pakai styled, hm. ini buildnya kenapa eror yak @ans-4175, boleh tolong dicekin?

Signed-off-by: Try Ajitiono <[email protected]>

ans-4175

but checking on build error first. Karena patch-package

Seharusnya urutannya?
yarn, yarn postinstall, gitu kan?

ans-4175 · 2021-11-20T16:09:36Z

README.md

+To apply the patches under the [patches](./patches) folder, do this in the root of this project:
+
+```shell
+yarn patch-package


yarn postinstall bukan harusnya?

o bener, yarn postinstall aja biar ngereference ke scripts, siap

ans-4175 · 2021-11-20T16:10:37Z

src/App.js

+    setDetailMerchant(undefined);
+    setMustStartRandomizing(true);
+    // Disable the tabs.
+    tabsRef.current.requestUpdate();


ans-4175 · 2021-11-20T16:11:37Z

src/App.js

    }
  }, [merchants]);

+  const randomizeText = randomizerMode === 'wheel' ? 'Spin' : 'Randomize';
+  const isMerchantDetailShown =


ans-4175 · 2021-11-20T16:13:26Z

src/components/WheelRandomizer.js

@@ -0,0 +1,25 @@
+import { Wheel } from 'react-custom-roulette';
+
+export default function WheelRandomizer({


nice pattern here

ans-4175 · 2021-11-20T16:20:37Z

Ini logicnya kita cek lagi, aku `spin` dan `randomize`-nya belum sesuai show rendernya

ans-4175 · 2021-11-20T17:24:32Z

Sudah bisa, aku perbaiki command install di vercel-nya, biar bisa patch package

ans-4175 · 2021-11-20T17:30:21Z

Aku agak bingung di patch, ini dia masalah pertama yang kutemui, onselected ini ga trigger event deh, aku coba pasang debug console.log function, ga kepanggil

Aku belum terlalu ngerti bikin 'diff' itu

imballinst · 2021-11-21T01:27:23Z

Seharusnya urutannya?
yarn, yarn postinstall, gitu kan?

iyak

Ini logicnya kita cek lagi, aku `spin` dan `randomize`-nya belum sesuai show rendernya

...bener, wah maaf 🤦 kemarin bugnya adalah ketika beres spin, terjadi race condition sehingga detail merchantnya nggak muncul (karena onChangeTab entah kenapa kepanggil juga)... terus saya remove beberapa fireSelected, terlihat bisa, eh ternyata yang textnya ngaco

Sudah bisa, aku perbaiki command install di vercel-nya, biar bisa patch package

siap, thanks!

Signed-off-by: Try Ajitiono <[email protected]>

imballinst · 2021-11-21T01:56:39Z

@ans-4175 harusnya sih udah bener, ya... tapi buildnya masih gagal, kenapa ya?

2021-11-21.08-49-45.mov

saya pengen nambahin test, tapi ditolak sama jest, soalnya si wired-elements ini dia targetnya es2017 bukan es2015 (atau lebih rendah)... jadi hasilnya masih ada keyword export (yang nggak ada di JS biasa) 😅 https://github.com/rough-stuff/wired-elements/blob/master/tsconfig.json#L3

imballinst added 3 commits November 18, 2021 20:47

separate to new component

129cd24

Signed-off-by: Try Ajitiono <[email protected]>

checkpoint

d6ac306

Signed-off-by: Try Ajitiono <[email protected]>

poush first

01b3512

Signed-off-by: Try Ajitiono <[email protected]>

vercel bot deployed to Preview November 18, 2021 14:54 View deployment

ans-4175 reviewed Nov 18, 2021

View reviewed changes

src/App.js Show resolved Hide resolved

ans-4175 reviewed Nov 18, 2021

View reviewed changes

src/App.js Outdated Show resolved Hide resolved

use roughjs 4.4

19960c6

Signed-off-by: Try Ajitiono <[email protected]>

need to validate

a14efa5

Signed-off-by: Try Ajitiono <[email protected]>

vercel bot deployed to Preview November 19, 2021 14:10 View deployment

revert

bbcbb84

Signed-off-by: Try Ajitiono <[email protected]>

vercel bot had a problem deploying to Preview November 19, 2021 14:13 Failure

yep

e464b40

Signed-off-by: Try Ajitiono <[email protected]>

vercel bot deployed to Preview November 19, 2021 14:14 View deployment

imballinst commented Nov 19, 2021

View reviewed changes

imballinst marked this pull request as ready for review November 19, 2021 14:17

imballinst changed the title ~~[wip] feat(text randomizer): implement text randomizer and toggle between wheel~~ feat(text randomizer): implement text randomizer and toggle between wheel Nov 19, 2021

ans-4175 requested changes Nov 20, 2021

View reviewed changes

imballinst added 2 commits November 20, 2021 09:21

fix consecutive randomizing causing result to be shown immediately

6c5de1d

Signed-off-by: Try Ajitiono <[email protected]>

center tabs after hard and painful work

38d2ba0

Signed-off-by: Try Ajitiono <[email protected]>

imballinst added 2 commits November 20, 2021 11:23

ok, now patch

70a4baf

Signed-off-by: Try Ajitiono <[email protected]>

patch and readme

ba130e8

Signed-off-by: Try Ajitiono <[email protected]>

vercel bot had a problem deploying to Preview November 20, 2021 04:29 Failure

fix errors

468a381

Signed-off-by: Try Ajitiono <[email protected]>

vercel bot had a problem deploying to Preview November 20, 2021 05:04 Failure

ans-4175 approved these changes Nov 20, 2021

View reviewed changes

fix text resetting and children gone

c8d136e

Signed-off-by: Try Ajitiono <[email protected]>

vercel bot had a problem deploying to Preview November 21, 2021 01:33 Failure

clean patches, want to add test, so add aria label first:

c8b8b9f

Signed-off-by: Try Ajitiono <[email protected]>

vercel bot had a problem deploying to Preview November 21, 2021 01:39 Failure

		@@ -0,0 +1,113 @@
		diff --git a/node_modules/wired-elements/lib/wired-lib.js b/node_modules/wired-elements/lib/wired-lib.js

		@@ -0,0 +1,25 @@
		import { Wheel } from 'react-custom-roulette';

		export default function WheelRandomizer({

feat(text randomizer): implement text randomizer and toggle between wheel #14

Are you sure you want to change the base?

feat(text randomizer): implement text randomizer and toggle between wheel #14

Conversation

imballinst commented Nov 18, 2021 • edited Loading

vercel bot commented Nov 18, 2021 • edited Loading

imballinst commented Nov 18, 2021

ans-4175 commented Nov 18, 2021

ans-4175 commented Nov 18, 2021

imballinst commented Nov 18, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imballinst commented Nov 18, 2021

imballinst commented Nov 18, 2021

imballinst commented Nov 18, 2021 • edited Loading

ans-4175 commented Nov 18, 2021

ans-4175 commented Nov 18, 2021

imballinst commented Nov 19, 2021

imballinst commented Nov 19, 2021 • edited Loading

wired-elements-react

wired-elements

ans-4175 commented Nov 19, 2021 via email

imballinst commented Nov 19, 2021

imballinst commented Nov 19, 2021

ans-4175 commented Nov 19, 2021 via email

imballinst commented Nov 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ans-4175 commented Nov 20, 2021

ans-4175 commented Nov 20, 2021

ans-4175 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imballinst Nov 20, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imballinst commented Nov 20, 2021

ans-4175 commented Nov 20, 2021 via email

imballinst commented Nov 20, 2021

ans-4175 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ans-4175 commented Nov 20, 2021

ans-4175 commented Nov 20, 2021

ans-4175 commented Nov 20, 2021

imballinst commented Nov 21, 2021

imballinst commented Nov 21, 2021 • edited Loading

imballinst commented Nov 18, 2021 •

edited

Loading

vercel bot commented Nov 18, 2021 •

edited

Loading

imballinst commented Nov 18, 2021 •

edited

Loading

imballinst commented Nov 19, 2021 •

edited

Loading

imballinst Nov 20, 2021 •

edited

Loading

imballinst commented Nov 21, 2021 •

edited

Loading