Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test gas payment with IBC token (backport #3866) #3881

Merged
merged 7 commits into from
Oct 3, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 3, 2024

Describe your changes

Adds an e2e test to check gas payment with an ibc token.
Misc typo fixes and docstrings.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #3866 done by [Mergify](https://mergify.com).

(cherry picked from commit 03fb4e2)
(cherry picked from commit dfe1bc4)
(cherry picked from commit 130252b)
(cherry picked from commit 40f0b7b)
(cherry picked from commit 1739449)
(cherry picked from commit 082c033)
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.20%. Comparing base (59db279) to head (6f02228).
Report is 11 commits behind head on 0.44.0.

Files with missing lines Patch % Lines
crates/sdk/src/tx.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           0.44.0    #3881      +/-   ##
==========================================
- Coverage   73.21%   73.20%   -0.02%     
==========================================
  Files         341      341              
  Lines      105150   105150              
==========================================
- Hits        76987    76975      -12     
- Misses      28163    28175      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic merged commit f067401 into 0.44.0 Oct 3, 2024
19 of 22 checks passed
@tzemanovic tzemanovic deleted the mergify/bp/0.44.0/pr-3866 branch October 3, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants