Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serde rename batch index into masp tx index #3860

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mateuszjasiuk
Copy link
Contributor

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@sug0 sug0 added bug Something isn't working client SDK cli and removed cli labels Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.03%. Comparing base (36ca7c3) to head (4093f0b).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3860      +/-   ##
==========================================
- Coverage   73.04%   73.03%   -0.01%     
==========================================
  Files         340      340              
  Lines      104816   104816              
==========================================
- Hits        76559    76552       -7     
- Misses      28257    28264       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 4, 2024
mergify bot added a commit that referenced this pull request Oct 4, 2024
Copy link
Contributor

mergify bot commented Oct 4, 2024

Hey @mateuszjasiuk, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Oct 4, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Oct 4, 2024
Copy link
Contributor

mergify bot commented Oct 4, 2024

Hey @mateuszjasiuk, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

it looks like this a breaking change for IBC (possibly in hermes) as it keeps failing in ibc_upgrade_client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-44 bug Something isn't working client merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants