Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean IBC E2E tests #3693

Merged
merged 12 commits into from
Aug 30, 2024
Merged

Clean IBC E2E tests #3693

merged 12 commits into from
Aug 30, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Aug 23, 2024

Describe your changes

closes #3601

  • Also refined the IBC client upgrade test with Gaia

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@yito88 yito88 changed the title Clean IBC E2E test Clean IBC E2E tests Aug 23, 2024
@yito88
Copy link
Member Author

yito88 commented Aug 23, 2024

The new ibc_upgrade_client test requires Gaia v18 or later: heliaxdev/namada-ci#4

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.01%. Comparing base (cc0a448) to head (fc002e5).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3693      +/-   ##
==========================================
- Coverage   68.01%   68.01%   -0.01%     
==========================================
  Files         330      330              
  Lines      116209   116208       -1     
==========================================
- Hits        79041    79040       -1     
  Misses      37168    37168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yito88 yito88 requested review from sug0 and grarco August 23, 2024 13:23
@yito88 yito88 requested a review from grarco August 27, 2024 05:16
@sug0
Copy link
Contributor

sug0 commented Aug 27, 2024

oh, the upgrade client ibc e2e test failed

@yito88
Copy link
Member Author

yito88 commented Aug 29, 2024

oh, the upgrade client ibc e2e test failed

That's expected. It needs a new gaia in CI. heliaxdev/namada-ci#4

@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 30, 2024
mergify bot added a commit that referenced this pull request Aug 30, 2024
mergify bot added a commit that referenced this pull request Aug 30, 2024
@mergify mergify bot merged commit 9d5da61 into main Aug 30, 2024
23 checks passed
@mergify mergify bot deleted the yuji/clean-ibc-e2e branch August 30, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up IBC E2E tests
4 participants