Mandatory CometBFT timestamp #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwgoes
previously approved these changes
Jan 12, 2024
Closed
tzemanovic
added a commit
that referenced
this pull request
Jan 16, 2024
* origin/grarco/comet-timestamp: Adds block timestamp in unit and integration tests Changelog #2383 Expect a proposed block to always carry a valid timestamp
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removes
get_block_timestampmethod. Inprocess_proposalalways require CometBFT to attach a valid timestamp to the block.Indicate on which release or other PRs this topic is based on
v0.29.0
Checklist before merging to
draft