Fee validation refactor #2382
Merged
Fee validation refactor #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tzemanovic
added a commit
that referenced
this pull request
Jan 16, 2024
* origin/grarco/fee-rafactor: Changelog #2382 Moves validation methods to functions Refactors `wrapper_fee_check`
tzemanovic
added a commit
that referenced
this pull request
Jan 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Refactors
wrapper_fee_checkinto three different functions, one for each consensus state (CheckTx,PrepareProposalandProcessProposal). Extract the fee unshield processing to a separate function. Also changes some methods ofShellto just be functions since we don't really need a reference to the shell.Indicate on which release or other PRs this topic is based on
v0.29.0
Checklist before merging to
draft