protocol: remove panic::catch_unwind for PoS VP
#2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
added a commit
that referenced
this pull request
Nov 10, 2023
tzemanovic
force-pushed
the
tomas/pos-vp-no-catch
branch
from
82d8c23
to
2f926d9
Compare
Closed
Closed
brentstone
pushed a commit
that referenced
this pull request
Nov 14, 2023
brentstone
force-pushed
the
tomas/pos-vp-no-catch
branch
from
2f926d9
to
c5d7d69
Compare
brentstone
added a commit
that referenced
this pull request
Nov 14, 2023
* tomas/pos-vp-no-catch: changelog: add #2145 protocol: remove `panic::catch_unwind` for PoS VP
brentstone
force-pushed
the
tomas/pos-vp-no-catch
branch
from
c5d7d69
to
517c81a
Compare
brentstone
added a commit
that referenced
this pull request
Nov 14, 2023
* tomas/pos-vp-no-catch: changelog: add #2145 protocol: remove `panic::catch_unwind` for PoS VP
brentstone
added a commit
that referenced
this pull request
Nov 14, 2023
* tomas/pos-vp-no-catch: changelog: add #2145 protocol: remove `panic::catch_unwind` for PoS VP
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/tomas/pos-vp-no-catch: changelog: add #2145 protocol: remove `panic::catch_unwind` for PoS VP
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/tomas/pos-vp-no-catch: changelog: add #2145 protocol: remove `panic::catch_unwind` for PoS VP
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/tomas/pos-vp-no-catch: changelog: add #2145 protocol: remove `panic::catch_unwind` for PoS VP
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/tomas/pos-vp-no-catch: changelog: add #2145 protocol: remove `panic::catch_unwind` for PoS VP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #21. We are safe to remove the temp panic catcher as the PoS VP currently only handles PoS params validation.
Indicate on which release or other PRs this topic is based on
v0.25.0
Checklist before merging to
draft