Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: switch to tower-abci branch with overloaded service handling #2103

Closed
wants to merge 2 commits into from
Closed

deps: switch to tower-abci branch with overloaded service handling #2103

wants to merge 2 commits into from

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Nov 6, 2023 •
edited
Loading

Describe your changes

heliaxdev/tower-abci#12:

  • added exponential backoff when a service overloaded
  • peek requests in case a service call fails to be able to retry them - this avoids crashing CometBFT (it should be possible to shed query requests when the query service is overloaded, but at the moment the implementation doesn't distinguish this and shedding mempool requests does crash Comet)

Indicate on which release or other PRs this topic is based on

0.25.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic marked this pull request as ready for review November 6, 2023 16:13
@tzemanovic tzemanovic marked this pull request as draft November 6, 2023 18:17
@tzemanovic
Copy link
Member Author

this is to be rebased on #2141 with a rebased tower-abci error handling fix

@tzemanovic
Copy link
Member Author

done with #2141 instead

@tzemanovic tzemanovic closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tzemanovic