-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi/multisig reordering #1794
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added max_signature_per_transaction genesis parameter
…ification, rebuild wasm_for_tests
murisi
force-pushed
the
murisi/multisig-reordering
branch
2 times, most recently
from
August 9, 2023 05:44
279e8cf
to
60a1583
Compare
murisi
force-pushed
the
murisi/multisig-reordering
branch
from
August 9, 2023 06:34
60a1583
to
39c0983
Compare
murisi
force-pushed
the
murisi/multisig-reordering
branch
3 times, most recently
from
August 9, 2023 13:11
5470e0d
to
a08faee
Compare
tzemanovic
reviewed
Aug 9, 2023
tzemanovic
reviewed
Aug 9, 2023
tzemanovic
reviewed
Aug 9, 2023
tzemanovic
reviewed
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left couple smaller comments, besides that LGTM
the cli params in |
murisi
force-pushed
the
murisi/multisig-reordering
branch
from
August 10, 2023 08:44
a08faee
to
a1e1d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Making the multisignature changes more compatible with hardware wallet signing. The core issue is that the final transaction building API settled upon needs to allow consumers to 1) build transactions 2) generate test vector 3) filter out sensitive sections 4) sign the transaction and 5) broadcast the transaction in that order. Some notes on the above ordering:
Tx
objectThe following changes have been made in order to achieve the above goal:
TxBuilder
API has been merged into theTx
API and thebuild
function has been removedTx
s will now be available to consumers.add_gas_payer
andadd_signing_keys
functions have been mutated intosign_wrapper
andsign_raw
.Indicate on which release or other PRs this topic is based on
Based on #1765 .
Checklist before merging to
draft