Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IBC amount handling #1784

Merged
merged 11 commits into from
Sep 6, 2023
Merged

Fix IBC amount handling #1784

merged 11 commits into from
Sep 6, 2023

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Aug 3, 2023

Describe your changes

Closes #1744

Indicate on which release or other PRs this topic is based on

v0.21.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@yito88 yito88 changed the title Yuji/fix ibc amount Fix IBC amount handling Aug 3, 2023
@yito88 yito88 mentioned this pull request Aug 9, 2023
2 tasks
@yito88 yito88 marked this pull request as ready for review August 15, 2023 14:12
@yito88 yito88 requested a review from sug0 August 15, 2023 14:12
Copy link
Contributor

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly some code style related comments/suggestions

core/src/ledger/ibc/context/common.rs Outdated Show resolved Hide resolved
core/src/ledger/ibc/mod.rs Outdated Show resolved Hide resolved
shared/src/ledger/tx.rs Outdated Show resolved Hide resolved
@yito88 yito88 mentioned this pull request Aug 28, 2023
yito88 added a commit that referenced this pull request Aug 30, 2023
yito88 added a commit that referenced this pull request Aug 30, 2023
Fraccaman added a commit that referenced this pull request Sep 6, 2023
* origin/yuji/fix-ibc-amount:
  for clippy
  refine code
  add changelog
  for clippy
  fix a test
  add a test for receiving no token
  fix denom update
  for clippy
  fix tests
  fix amount conversion
  IBC transfer for non-native denom
Fraccaman added a commit that referenced this pull request Sep 6, 2023
* origin/yuji/fix-ibc-amount:
  for clippy
  refine code
  add changelog
  for clippy
  fix a test
  add a test for receiving no token
  fix denom update
  for clippy
  fix tests
  fix amount conversion
  IBC transfer for non-native denom
Fraccaman added a commit that referenced this pull request Sep 6, 2023
* origin/yuji/fix-ibc-amount:
  for clippy
  refine code
  add changelog
  for clippy
  fix a test
  add a test for receiving no token
  fix denom update
  for clippy
  fix tests
  fix amount conversion
  IBC transfer for non-native denom
@Fraccaman Fraccaman merged commit 2d089f6 into main Sep 6, 2023
11 of 12 checks passed
@Fraccaman Fraccaman deleted the yuji/fix-ibc-amount branch September 6, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix amount handling in IBC transfer
3 participants