Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternative draft 0.20 #1740

Closed
wants to merge 144 commits into from
Closed

alternative draft 0.20 #1740

wants to merge 144 commits into from

Conversation

juped and others added 30 commits June 27, 2023 16:31
Add the epoch-sleep helper, which queries the current epoch and then
sleeps until the epoch is greater (polling once a second). This can
replace the multiple namadac invocations used in e2e tests.
Instead of manually querying, we now epoch-sleep until the next epoch,
limiting the number of clients invoked to 1.

Also update the epoch sleep e2e test to check the return value (parsed
from the output of epoch-sleep).
PoS hammered the node as fast as possible with epoch queries in its
tests to wait for a specified epoch. Instead, epoch-sleep repeatedly
until the target epoch has been reached.

This could be improved further by adding an --until parameter to
epoch-sleep.
tzemanovic and others added 19 commits July 18, 2023 09:35
* tiago/remove-native-vp-addr:
  changelog: add #1725
  Remove `ADDR` associated type from native VPs
* main:
  ci: clean up
  fix formatting
  don't use flaky sleep
  refactor creation of namada nodes
  make Who clonable
  test/e2e/slashing: wait for wasm on original validator
  test/e2e/proposal_submission: wait for proposal to be committed
  test/e2e/double_signing: path for validator copy that keeps logs in CI
  remove more --mode argument in the generator script
  remove deprecated --mode argument in scripts
* origin/tomas/pos-fix-rewards-boundary:
  changelog: add #1729
  test/ledger/finalize_block: fix slashing tests
  pos/slash: fix the validator state update to be in sync with set changes
  app/ledger/finalize_block: log block rewards before recording slashes
  test/e2e/slashing: extend the test to discover rewards issues
  pos: error out if validator is not in expected state for rewards
* origin/tomas/pos-data-history:
  changelog: add #1733
  pos/epoched: keep 2 past epochs of data by default
* bat/feature/refactor-cli:
  [feat]: Moved cli commands common to testing, cli, and sdk out into apps
@tzemanovic
Copy link
Member Author

tzemanovic commented Jul 21, 2023

I'm removing #1693 for now as there is an issue (see #1693 (comment)) that's still happening here and using #1714 unfortunately doesn't help in debugging it

* bat/refactor-masp-e2e:
  changelog: add #1714
  rustdoc: rm links to private symbols
  clippy fix
  make: build tests with nightly
  tests: enable feature(internal_output_capture) for tests only
  [feat]: Re-used code from the cli using new CliApi type
  [chore]: Move mock definitions into apps to re-restrict visibility. Better implementation of mock stdin
  [chore]: Replaced dev with testing feature flag on stio redirect func
  [chore]: Re-add #[cfg(test)] to test router modules
  Update apps/src/lib/cli/utils.rs
  Update tests/src/integration/masp.rs
  [chore]: Add lazy_static as workspace dep
  Update tests/Cargo.toml
  [chore]: Making the docs happy
  [chore]: Removed unnecessary  visibility qualifier
  [fix]: Cleanups
  [fix]: Resolved conflicts with eth bridge cli changes
  [fix]: Indentified flakiness in masp_txs_and_queries
  [feat]: All masp e2e tests refactored into integration tests. Update Makefile with integration test recipes
  [feat]: Added masp_txs_and_queries integration test which passes. Removed e2e tests which now have passing integration counterparts
  [feat]: Added masp pinned tx test which passes
  [fix]: Porting over masp incentives e2e test
  [fix]: Fixed the faucet to use uint instead of amount. This makes it portable across different assets
  [feat]: First basic integration test passing with plumbing
  [feat]: Implement mock cli and client for integration tests
  converts faucet_withdrawal_limit to be correct
  fixup! WIP refactoring masp e2e tests
  WIP refactoring masp e2e tests
@Fraccaman
Copy link
Member

the invalid_transaction e2e test crashed because of timing issues. Is this ready to be released?

@Fraccaman Fraccaman closed this Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants