-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to multitokens #1663
Closed
yito88
wants to merge
14
commits into
tiago/ethbridge/v0.17.5
from
yuji/tiago/ethbridge/v0.17.5/ibc-multitoken
Closed
Change to multitokens #1663
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6f0fd94
clean denom validation
yito88 367dbd2
change multitoken
yito88 9c6f1a6
change to multitokens
yito88 efc48b7
add multitoken VP file
yito88 3b9c48c
fix balance print
yito88 eb84e36
fix token decoding
yito88 34c9677
rename
yito88 fa377e3
remove InternalAddress::Minted
yito88 a20738d
add unit tests
yito88 7bad2a2
change eth_bridge balance keys to multitoken keys
yito88 ea52047
revert unexpected changes
yito88 20c5474
modify EthBridge VP and EthBridgePool VP for multitoken
yito88 a3070c1
for clippy
yito88 8fa683b
fix multitoken vp to check the minter
yito88 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we document the purpose of each of these match arms? reading this code is hard, especially with these short identifiers (i.e.
t
,o
ands
), which have no immediate meaning