Multisignature (1/3) #1606
Closed
Multisignature (1/3) #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
reviewed
Jul 17, 2023
Comment on lines
+198
to
+205
| Key { | ||
| segments: vec![ | ||
| DbKeySeg::AddressSeg(ADDRESS), | ||
| DbKeySeg::StringSeg( | ||
| Keys::VALUES.max_signatures_per_transaction.to_string(), | ||
| ), | ||
| ], | ||
| } |
There was a problem hiding this comment.
Suggested change
| Key { | |
| segments: vec![ | |
| DbKeySeg::AddressSeg(ADDRESS), | |
| DbKeySeg::StringSeg( | |
| Keys::VALUES.max_signatures_per_transaction.to_string(), | |
| ), | |
| ], | |
| } | |
| is_max_signatures_per_transaction_key_at_addr(key, &ADDRESS) |
I think this should work. the StorageKeys macro generates these predicate functions automatically
Fraccaman
added a commit
that referenced
this pull request
Jul 20, 2023
* fraccaman/multisignature-draft-rebase: added changelog test: fix e2e test test: fix unit tests wasm: added new account methods to tx_prelude, refactor signature verifiation, rebuild wasm_for_tests docs: update tx definitions apps,shared: added cli tx and query methods core: added multisignature tx format, refacctor account storage api, added max_signature_per_transaction genesis parameter
Fraccaman
added a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on 0.17.4.