Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IBC token VP to reject invalid refund #1461

Closed
wants to merge 1 commit into from
Closed

Fix IBC token VP to reject invalid refund #1461

wants to merge 1 commit into from

Conversation

yito88
Copy link
Member

@yito88 yito88 commented May 24, 2023

closes #1460

@yito88 yito88 requested a review from cwgoes May 24, 2023 08:25
cwgoes
cwgoes requested changes May 25, 2023
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this check is sufficiently specific - we need to check that the transfer(s) performed corresponded to the executed IBC message, no?

@cwgoes
Copy link
Contributor

cwgoes commented May 25, 2023

Also, if we're just checking that another VP has also been called, can't we check that with the verifiers field?

@yito88
Copy link
Member Author

yito88 commented Jun 13, 2023

This will be fixed in #1526

@yito88 yito88 closed this Jun 13, 2023
@yito88 yito88 deleted the yuji/fix-ibc-token-vp branch July 24, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IBC Token VP should check if IBC-related data has been changed
2 participants
@yito88 @cwgoes