Make the the backing integer type for amounts 256 bit #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
commented
Apr 21, 2023
batconjurer
commented
Apr 21, 2023
…into bat/feature/uint256_amount
For some reason Ι believe if we wait an epoch we get pinned transactions more reliably showing through
|
pls update wasm |
|
Note for real history, merge #1630 into main. Eth integration + amounts can still use this branch as they share a common ancestor, and the existence of this branch should make it easier to reuse existing work. |
|
Closed as completed by #1630. |
This was referenced Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be compatible with the Ethereum and IBC ecosystems, we need native support for token amounts with a backing 256 bit unsigned integer. This furthermore needs to be integrated with MASP, we requires breaking these amounts down in 64 bit words.
This PR also includes a new type
Decthat replaces the dependency on therust_decimalcrate and provides a fixed-precision decimal number for computations that require it (mostly in proof-of-stake)