evil: #2322

anoma · Dec 28, 2023 · e59dbfe · e59dbfe
1 parent e1b2745
commit e59dbfe
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/apps/src/lib/client/tx.rs b/apps/src/lib/client/tx.rs
@@ -968,7 +968,7 @@ where
         &args.source.effective_address(),
     )
     .await?;
-    let (mut tx, signing_data) = args.build(namada).await?;
+    let (mut tx, signing_data, _) = args.build(namada).await?;
 
     if args.tx.dump_tx {
         tx::dump_tx(namada.io(), &args.tx, tx);
@@ -977,6 +977,8 @@ where
 
         namada.submit(tx, &args.tx).await?;
     }
+    // NOTE that the tx could fail when its submission epoch doesn't match
+    // construction epoch
 
     Ok(())
 }

diff --git a/core/src/types/ibc.rs b/core/src/types/ibc.rs
@@ -16,8 +16,8 @@ use crate::ibc::apps::transfer::types::{Memo, PrefixedDenom, TracePath};
 use crate::ibc::core::handler::types::events::{
     Error as IbcEventError, IbcEvent as RawIbcEvent,
 };
-pub use crate::ledger::ibc::storage::is_ibc_key;
 use crate::ibc::primitives::proto::Protobuf;
+pub use crate::ledger::ibc::storage::is_ibc_key;
 use crate::tendermint::abci::Event as AbciEvent;
 use crate::types::masp::PaymentAddress;
 use crate::types::token::Transfer;

diff --git a/sdk/src/args.rs b/sdk/src/args.rs
@@ -397,7 +397,8 @@ impl TxIbcTransfer {
     pub async fn build(
         &self,
         context: &impl Namada,
-    ) -> crate::error::Result<(crate::proto::Tx, SigningTxData)> {
+    ) -> crate::error::Result<(crate::proto::Tx, SigningTxData, Option<Epoch>)>
+    {
         tx::build_ibc_transfer(context, self).await
     }
 }