Merge pull request #3700 from anoma/grarco/fix-error-mishandling

Propagates error from `is_proposal_accepted`

.changelog/unreleased/bug-fixes/3700-fix-error-mishandling.md

@@ -0,0 +1,3 @@
+- Now we propagate the error coming from
+  `is_proposal_accepted` instead of falling back on a default.
+  ([\#3700](https://github.com/anoma/namada/pull/3700))

crates/governance/src/vp/mod.rs

@@ -90,9 +90,7 @@ where
         if is_proposal_accepted(
             &self.ctx.pre(),
             tx_data.tx.data(tx_data.cmt).unwrap_or_default().as_ref(),
-        )
-        .unwrap_or_default()
-        {
+        )? {
             return Ok(());
         }
 

crates/governance/src/vp/pgf.rs

@@ -65,9 +65,7 @@ where
                 .data(batched_tx.cmt)
                 .unwrap_or_default()
                 .as_ref(),
-        )
-        .unwrap_or_default()
-        {
+        )? {
             return Ok(());
         }
 

crates/ibc/src/vp/mod.rs

@@ -157,9 +157,7 @@ where
                 .data(batched_tx.cmt)
                 .unwrap_or_default()
                 .as_ref(),
-        )
-        .unwrap_or_default()
-        {
+        )? {
             return Ok(());
         }
 

crates/trans_token/src/vp.rs

@@ -77,9 +77,7 @@ where
         if Gov::is_proposal_accepted(
             &self.ctx.pre(),
             tx_data.tx.data(tx_data.cmt).unwrap_or_default().as_ref(),
-        )
-        .unwrap_or_default()
-        {
+        )? {
             return Ok(());
         }