Skip to content

Commit

Permalink
Merge branch 'murisi/masp-ibc-replay-protection-using-txdata-on-0.39.…
Browse files Browse the repository at this point in the history
…0' (#3409)

* origin/murisi/masp-ibc-replay-protection-using-txdata-on-0.39.0:
  Added changelog entry.
  Update balances in the MASP using a non-mutating style.
  Now charge gas in IBC denom query.
  Start using IBC ports to determine message formats.
  Added more comments and improved function naming.
  Simplify checking packet acknowledgement by assuming the uniqueness of the success acknowledgement.
  Removed is_any_shielded_action_balance_key and related code since thats no longer used.
  Now map denominations to tokens using ibc_token instead of reverse_query_denom.
  Subdivided some functions involved in processing IBC packets.
  Reduced the dependence on IBC events.
  Ensure that native tokens can always be decoded.
  Handle the is_sender_chain_source case in the MASP VP.
  Centralized the construction of TransparentAddresses to ensure that encodings are consistent.
  Split up the IBC validation logic in MASP.
  Now check that the IBC events are valid with respect to storage changes.
  Created a separate type that is either an Address or IBC receiver.
  Modified the MASP VP to check the IBC receivers.
  Now hash the TransferTarget into Transaction transparent outputs.
  • Loading branch information
brentstone committed Jul 4, 2024
2 parents f479d3d + 7ff94bd commit 672a3d2
Show file tree
Hide file tree
Showing 49 changed files with 735 additions and 375 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Add replay protection to MASP-IBC transactions.
([\#3409](https://github.com/anoma/namada/pull/3409))
2 changes: 1 addition & 1 deletion .github/workflows/scripts/hermes.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.8.2-namada-beta12-rc
1.8.2-namada-beta12-rc3
108 changes: 49 additions & 59 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/benches/native_vps.rs
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ fn prepare_ibc_tx_and_ctx(bench_name: &str) -> (BenchShieldedCtx, BatchedTx) {
shielded_ctx.generate_shielded_action(
Amount::native_whole(10),
TransferSource::ExtendedSpendingKey(albert_spending_key),
TransferTarget::Address(defaults::bertha_address()),
defaults::bertha_address().to_string(),
)
}
_ => panic!("Unexpected bench test"),
Expand Down
1 change: 1 addition & 0 deletions crates/core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ proptest = {workspace = true, optional = true}
prost-types.workspace = true
rand = {version = "0.8", optional = true}
rand_core = {version = "0.6", optional = true}
ripemd.workspace = true
serde.workspace = true
serde_json.workspace = true
sha2.workspace = true
Expand Down
Loading

0 comments on commit 672a3d2

Please sign in to comment.