Merge pull request #3589 from anoma/brent/misc-improvements

Various misc improvements

.changelog/unreleased/improvements/3589-misc-improvements.md

@@ -0,0 +1,2 @@
+- Fxing comments and strings.
+  ([\#3589](https://github.com/anoma/namada/pull/3589))

crates/apps_lib/src/cli.rs

@@ -2281,7 +2281,7 @@ pub mod cmds {
         fn def() -> App {
             App::new(Self::CMD)
                 .about(wrap!(
-                    "Submit a tx to reveal the public key an implicit \
+                    "Submit a tx to reveal the public key of an implicit \
                      account. Typically, you don't have to do this manually \
                      and the client will detect when a tx to reveal PK is \
                      needed and submit it automatically. This will write the \

crates/apps_lib/src/client/rpc.rs

@@ -669,7 +669,7 @@ pub async fn query_protocol_parameters(
         display_line!(context.io(), "{:8}{}: {:?}", "", token, gas_cost);
     }
 
-    display_line!(context.io(), "PoS parameters");
+    display_line!(context.io(), "\nPoS parameters");
     let pos_params = query_pos_parameters(context.client()).await;
     display_line!(
         context.io(),
@@ -697,9 +697,9 @@ pub async fn query_protocol_parameters(
     );
     display_line!(
         context.io(),
-        "{:4}Validator stake threshold: {}",
+        "{:4}Validator stake threshold: {} NAM",
         "",
-        pos_params.validator_stake_threshold
+        pos_params.validator_stake_threshold.to_string_native()
     );
     display_line!(
         context.io(),

crates/core/src/address.rs

@@ -609,7 +609,7 @@ impl Display for InternalAddress {
                 Self::Erc20(eth_addr) => format!("Erc20: {}", eth_addr),
                 Self::Nut(eth_addr) => format!("Non-usable token: {eth_addr}"),
                 Self::Multitoken => "Multitoken".to_string(),
-                Self::Pgf => "PublicGoodFundings".to_string(),
+                Self::Pgf => "PGF".to_string(),
                 Self::Masp => "MASP".to_string(),
                 Self::ReplayProtection => "ReplayProtection".to_string(),
                 Self::TempStorage => "TempStorage".to_string(),
@@ -629,6 +629,7 @@ impl InternalAddress {
             "governance" => Some(InternalAddress::Governance),
             "masp" => Some(InternalAddress::Masp),
             "replayprotection" => Some(InternalAddress::ReplayProtection),
+            "pgf" => Some(InternalAddress::Pgf),
             _ => None,
         }
     }

crates/core/src/uint.rs

@@ -472,7 +472,7 @@ impl Uint {
 }
 
 /// The maximum absolute value a [`I256`] may have.
-/// Note the the last digit is 2^63 - 1. We add this cap so
+/// Note the last digit is 2^63 - 1. We add this cap so
 /// we can use two's complement.
 pub const MAX_SIGNED_VALUE: Uint =
     Uint([u64::MAX, u64::MAX, u64::MAX, 9223372036854775807]);

crates/node/src/ethereum_oracle/events.rs

@@ -43,7 +43,7 @@ pub mod eth_events {
 
     impl PendingEvent {
         /// Decodes bytes into an [`EthereumEvent`] based on the signature.
-        /// This is is turned into a [`PendingEvent`] along with the block
+        /// This is turned into a [`PendingEvent`] along with the block
         /// height passed in here.
         ///
         /// If the event contains a confirmations field,

crates/parameters/src/lib.rs

@@ -297,7 +297,7 @@ where
         .into_storage_result()
 }
 
-/// Read the the epoch duration parameter from store
+/// Read the epoch duration parameter from store
 pub fn read_epoch_duration_parameter<S>(
     storage: &S,
 ) -> namada_storage::Result<EpochDuration>
@@ -312,7 +312,7 @@ where
         .into_storage_result()
 }
 
-/// Read the the masp epoch multiplier parameter from store
+/// Read the masp epoch multiplier parameter from store
 pub fn read_masp_epoch_multiplier_parameter<S>(
     storage: &S,
 ) -> namada_storage::Result<u64>

crates/proof_of_stake/src/tests/test_validator.rs

@@ -625,7 +625,7 @@ fn test_validator_sets() {
     );
     assert_eq!(tm_updates[1], ValidatorSetUpdate::Deactivated(pk2));
 
-    // Unbond some stake from val1, it should be be swapped with the greatest
+    // Unbond some stake from val1, it should be swapped with the greatest
     // below-capacity validator val2 into the below-capacity set. The stake of
     // val1 will go below 1 NAM, which is the validator_stake_threshold, so it
     // will enter the below-threshold validator set.
@@ -836,7 +836,7 @@ fn test_validator_sets() {
     );
     assert_eq!(tm_updates[1], ValidatorSetUpdate::Deactivated(pk1));
 
-    // Bond some stake to val6, it should be be swapped with the lowest
+    // Bond some stake to val6, it should be swapped with the lowest
     // consensus validator val2 into the consensus set
     let bond = token::Amount::from_uint(500_000, 0).unwrap();
     let stake6 = stake6 + bond;

crates/tests/src/e2e/ledger_tests.rs

@@ -1075,7 +1075,7 @@ where
 /// 4. Run it to get it to double vote and sign blocks
 /// 5. Submit a valid token transfer tx to validator 0
 /// 6. Wait for double signing evidence
-/// 7. Make sure the the first validator can proceed to the next epoch
+/// 7. Make sure the first validator can proceed to the next epoch
 #[test]
 fn double_signing_gets_slashed() -> Result<()> {
     use std::net::SocketAddr;
@@ -1362,7 +1362,7 @@ fn double_signing_gets_slashed() -> Result<()> {
         .exp_regex(r"Validator [a-z0-9]+ is in the .* set")
         .unwrap();
 
-    // 7. Make sure the the first validator can proceed to the next epoch
+    // 7. Make sure the first validator can proceed to the next epoch
     epoch_sleep(&test, &validator_one_rpc, 120)?;
 
     // Make sure there are no errors

crates/vm/src/wasm/compilation_cache/common.rs

@@ -116,7 +116,7 @@ impl<N: CacheName, A: WasmCacheAccess> Cache<N, A> {
     /// Get a WASM module from LRU cache, from a file or compile it and cache
     /// it. If the cache access is set to [`crate::WasmCacheRwAccess`], it
     /// updates the position in the LRU cache. Otherwise, the compiled
-    /// module will not be be cached, if it's not already.
+    /// module will not be cached, if it's not already.
     pub fn fetch(
         &mut self,
         code_hash: &Hash,