Add deploy and release workflow to CI #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
force-pushed
the
357/ci-extension-assets
branch
2 times, most recently
from
0542dfe
to
a86b39f
Compare
emccorson
force-pushed
the
357/ci-extension-assets
branch
3 times, most recently
from
1277d10
to
e51c5f4
Compare
jurevans
reviewed
Aug 30, 2023
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| REACT_APP_NAMADA_ALIAS: |
There was a problem hiding this comment.
Since the faucet PR was just recently merged, we could include those env vars as inputs (as we'll need the faucet address & limit set when connected to testnet):
## From .env.sample
REACT_APP_NAMADA_FAUCET_ADDRESS=atest1v4ehgw368pprgvjygv652w2yg3znvd69xucnvde3xaz5ysenx5myx3f389z5yv3nxg65xv3kx0fkez
REACT_APP_NAMADA_FAUCET_LIMIT=1000
Note that they should not be required though, as they don't apply to mainnet.
I'll open a separate PR at some point to add any IBC-related environment vars to this!
There was a problem hiding this comment.
Ok, I will add the two variables on with these defaults 👍
mateuszjasiuk
approved these changes
Aug 30, 2023
emccorson
force-pushed
the
357/ci-extension-assets
branch
3 times, most recently
from
9e7078f
to
8c25c08
Compare
emccorson
force-pushed
the
357/ci-extension-assets
branch
from
1977135
to
4ba56fc
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CI workflow that can be manually run to deploy the interface to namada.me and create a GitHub release of the extension with given parameters (e.g. Namada chain ID).
I haven't been able to test the Netlify deploy part since the workflow can only be run when it is in main, so this might need fixed up after it is merged.
#352 can probably be closed when this is merged.
Added
Add deploy and release workflow to CI. Closes #357.
Removed
Remove deploy to namada.me on merge to main