Improve extension errors #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
changed the title
jurevans
approved these changes
Aug 2, 2023
emccorson
force-pushed
the
fix/better-extension-errors
branch
from
8929e4e
to
8890336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where background errors were getting logged as
[Object, object]in Chrome, and adds source maps for the extension on Firefox in development mode. These changes should make error reporting in the extension better.I wanted to add source maps for Chrome, but the type of source map I chose uses
eval, which is not supported in manifest v3. There are non-eval source maps, but these crashed webpack when I tried them.Changed
Added