Unify duplicate eslint config files #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
force-pushed
the
chore/dry-eslint-config
branch
from
fa6b49d
to
4b55b4b
Compare
This commit adds a new package `@namada/eslint-config` which contains the eslint configs that the other packages should extend.
emccorson
force-pushed
the
chore/dry-eslint-config
branch
from
4b55b4b
to
3c4f4a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in main we have two eslint config files which are duplicated across our packages. This PR replaces the duplicate files with a new package
@namada/eslint-configwhich contains a single copy of each config that other packages can extend from.This PR should not substantially change the behaviour of the linting (although package bumps might have caused minor changes). This can be checked with
eslint --print-config.Changed
@namada/eslint-config.@namada/eslint-config.Removed
eslint-config-airbnb,eslint-plugin-jsx-a11y).