feat/311 - Implement ledger integration improvements #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
changed the title
jurevans
force-pushed
the
feat/311-ledger-improvements
branch
from
5b0fc52
to
277ddc2
Compare
jurevans
force-pushed
the
feat/311-ledger-improvements
branch
from
05dad47
to
7438494
Compare
Consolidate approval views for all tx types Hook up Ledger transfer Remove unused address from messages Consolidate tx build calls Clean up Message and component props
jurevans
force-pushed
the
feat/311-ledger-improvements
branch
from
7438494
to
8ecc65b
Compare
jurevans
changed the title
emccorson
reviewed
Jul 27, 2023
emccorson
approved these changes
Jul 27, 2023
mateuszjasiuk
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #311
transferfrom Ledger account worksunbondfrom Ledger account workswithdrawfrom Ledger account worksApproveTx)submit_signed_tx)NOTE I did a little bit of clean up outside the scope of this PR (discovered some out-of-date and unused code)
Testing
Setup
v0.18.1, do not build wasm scripts! We want the wasms that are delivered through AWS (and remember to fix the CORS setting in the chain'sconfig.toml, e.g.,local.c4463480b0eb1dbf83a1d0d0/setup/validator-0/.namada/local.c4463480b0eb1dbf83a1d0d0/config.toml), then start that chain and set up a wallet (CLI)./installer_s2.sh load(e.g., if you're using a Ledger Nano S-Plus) (Ping me for a copy of the installer script you need for your Ledger)Add Account- from the new tab, clickConnect to Ledger, then give it an alias, then clickAdd to wallet and closenamadaCLI, transfer tokens to your initial account and your Ledger (for testing both Bond tx from a local wallet account as well as from Ledger, as both of these are updated in this PR)