chore - Update to SDK changes in namada v0.18.1 #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
requested review from
mateuszjasiuk and
emccorson
and removed request for
mateuszjasiuk
mateuszjasiuk
approved these changes
Jul 7, 2023
| // Submit the reveal public key transaction first | ||
| namada::ledger::tx::process_tx(&self.client, &mut self.wallet, &args, rtx).await?; | ||
| // Update the stateful PoW challenge of the outer transaction | ||
| #[cfg(not(feature = "mainnet"))] |
There was a problem hiding this comment.
We most likely have to add "mainnet" feature to Cargo.toml and to the release/mainnet builds. Worth asking someone about this flag :)
jurevans
force-pushed
the
chore/update-to-namada-v0.18.1
branch
from
87f8de2
to
d100332
Compare
mateuszjasiuk
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Update to SDK changes in namada v0.18.1 * Add public key to schema, tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates us to support
namadav0.18.1, which contains the refactoring of the SDK calls.NOTE We can now pass an optional
publicKeyalong with our transactions, so this has been added to thetxschema andTxPropstype, but isn't yet being passed in. It is required to be there so tx can be deserialized in Rust.