Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use wasm-pack for builds #326

Merged
merged 1 commit into from
Jul 10, 2023
Merged

refactor: use wasm-pack for builds #326

merged 1 commit into from
Jul 10, 2023

Conversation

mateuszjasiuk
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk commented Jul 7, 2023 •
edited
Loading

wasm-pack has built in support for wasm-opt, so it makes sense to use it for builds
I've also changed:

  • opt levels a bit, not sure if it helps with anything though :D
  • test build profile to dev as it does skip optimizations

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

🚀 Deployed on https://pull-request-326--wallet-development-heliax-dev.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 7, 2023 09:53 Inactive
jurevans
jurevans approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@jurevans jurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mateuszjasiuk mateuszjasiuk merged commit d512917 into main Jul 10, 2023
5 checks passed
@mateuszjasiuk mateuszjasiuk deleted the refactor/use-wasm-pack-for-builds branch September 13, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurevans jurevans jurevans approved these changes

@emccorson emccorson Awaiting requested review from emccorson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateuszjasiuk @jurevans