Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: do not decrypt mnemonic for auth #322

Merged
merged 2 commits into from
Jul 10, 2023
Merged

feat: do not decrypt mnemonic for auth #322

merged 2 commits into from
Jul 10, 2023

Conversation

mateuszjasiuk
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk commented Jul 3, 2023 •
edited
Loading

Resolves #199

@mateuszjasiuk mateuszjasiuk force-pushed the refactor/do-not-decrypt-mnemonic branch from 74e1d57 to dd1af23 Compare July 4, 2023 09:27
@github-actions
Copy link

github-actions bot commented Jul 4, 2023 •
edited
Loading

🚀 Deployed on https://pull-request-322--wallet-development-heliax-dev.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 4, 2023 09:38 Inactive
jurevans
jurevans approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@jurevans jurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@mateuszjasiuk mateuszjasiuk force-pushed the refactor/do-not-decrypt-mnemonic branch from dd1af23 to b9ad4ee Compare July 10, 2023 09:40
@github-actions github-actions bot temporarily deployed to pull request July 10, 2023 09:52 Inactive
@mateuszjasiuk mateuszjasiuk merged commit 3110ff4 into main Jul 10, 2023
5 checks passed
mateuszjasiuk added a commit that referenced this pull request Jul 10, 2023
@mateuszjasiuk
Revert "feat: do not decrypt mnemonic for auth (#322)"
fe60293 
This reverts commit 3110ff4.
@mateuszjasiuk mateuszjasiuk deleted the refactor/do-not-decrypt-mnemonic branch September 13, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurevans jurevans jurevans approved these changes

@emccorson emccorson Awaiting requested review from emccorson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extension: Authentication should not decrypt mnemonic
2 participants
@mateuszjasiuk @jurevans