feat: cleanup memory on rust panic #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
reviewed
Jun 29, 2023
packages/shared/src/index.ts
Outdated
| (...args: U): Promise<T> => { | ||
| return new Promise(async (resolve, reject) => { | ||
| const t = setTimeout(() => { | ||
| reject(`Balance query timed out after ${timeout}s.`); |
There was a problem hiding this comment.
Maybe we could do something like promiseWithTimeout where we pass in the error message as an arg to display, as these are not all balance queries?
There was a problem hiding this comment.
Ah yeah :) Focused too much on balances 👍
jurevans
approved these changes
Jun 29, 2023
emccorson
added a commit
that referenced
this pull request
Jul 3, 2023
This fixes a bug introduced in #317 where `new Query` cannot be called because Query was transpiled to ES5 and relies on the class it extends to also be transpiled, but the parent class was generated from Rust and not transpiled. target JS version for namada-interface too.
emccorson
added a commit
that referenced
this pull request
Jul 3, 2023
This fixes a bug introduced in #317 where `new Query` cannot be called because Query was transpiled to ES5 and relies on the class it extends to also be transpiled, but the parent class was generated from Rust and not transpiled. PR #317 already fixed this for the extension; this commit just sets the target JS version for namada-interface too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
What've changed:
wasm:build:devwasm:build:devwe define panic_hook - addeddevfeaturees2015to be able to extend generated Query classWe can do something similar for the Sdk class, it might be a bit tricky though as for example submit shielded transfer can take a while