Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: Additional tests around shielded keys #1129

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Sep 19, 2024

Someone on Discord has reported that when testing import of the same mnemonic in the extension, sometimes their Payment Address is different. I'm not sure how this could be possible, and we have existing tests that ensure that the keys must match for any given mnemonic.

So, I propose:

  • Add additional tests to the @namada/crypto lib (Rust & Jest)
    • Imported mnemonic generates the same seed
    • Payment Address & Viewing Key match expected when deriving from seed
  • Add additional tests to @heliax/namada-sdk package (we currently have one test mnemonic, will add more)
  • Ensure these tests are being run in CI each time

Testing

  • packages/crypto
    • yarn test-wasm:ci
    • yarn test
  • packages/sdk
    • yarn test

@jurevans jurevans self-assigned this Sep 19, 2024
@jurevans jurevans changed the title Additional tests around shielded keys WIP: Additional tests around shielded keys Sep 19, 2024
@jurevans jurevans force-pushed the tests/additional-tests-for-shielded-accounts branch from e8413aa to d5e383f Compare September 19, 2024 14:28
@jurevans jurevans marked this pull request as ready for review September 20, 2024 13:20
@jurevans jurevans changed the title WIP: Additional tests around shielded keys packages: Additional tests around shielded keys Sep 20, 2024
@jurevans jurevans force-pushed the tests/additional-tests-for-shielded-accounts branch from d5e383f to 0149872 Compare September 23, 2024 13:13
@jurevans jurevans force-pushed the tests/additional-tests-for-shielded-accounts branch from 0149872 to b3116da Compare September 23, 2024 13:14
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jurevans jurevans merged commit 77f10cd into main Sep 25, 2024
10 checks passed
@jurevans jurevans deleted the tests/additional-tests-for-shielded-accounts branch September 25, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants