POC/WIP: feat/1098 - Fetch and store MASP params in background #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
changed the base branch from
feat/1098-add-remaining-transfer-types
to
main
jurevans
changed the base branch from
main
to
feat/1098-add-remaining-transfer-types
jurevans
changed the base branch from
feat/1098-add-remaining-transfer-types
to
main
jurevans
force-pushed
the
feat/1098-sw-masp-params
branch
from
00963f3
to
923622f
Compare
jurevans
changed the base branch from
main
to
feat/1098-add-remaining-transfer-types
* feat: make extension optional * fix: remove unneeded message
jurevans
force-pushed
the
feat/1098-sw-masp-params
branch
from
923622f
to
6faf1f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1098 & #1099
Namadillo will need to fetch and store MASP params once. This PR is to experiment with fetching these within a service worker and storing these in IndexedDB.
To move this PR out of POC status, we need a smoother development & build integration. Currently, packages cannot be imported into this context (specifically,
@namada/storagewhich is the IndexedDB interface we use). For this branch, I am just using a copied version for now. We will potentially be able to improve the Vite pipeline & dev process for working with SW.Also, to avoid CORS issues, I've had to proxy while working locally. This is not ideal, but is an issue regardless of whether we request in the App vs SW.