Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker nginx config #1112

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: docker nginx config #1112

merged 1 commit into from
Sep 19, 2024

Conversation

Fraccaman
Copy link
Member

No description provided.

@Fraccaman Fraccaman force-pushed the fraccaman/improve-docker-images branch from 30c185b to df47baa Compare September 14, 2024 11:23
@Fraccaman Fraccaman force-pushed the fraccaman/improve-docker-images branch from df47baa to 34dbe78 Compare September 14, 2024 11:28
@Fraccaman Fraccaman marked this pull request as ready for review September 14, 2024 11:32
pedrorezende
pedrorezende approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@pedrorezende pedrorezende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! But can we rollback the changes on gzip, since we found the error?

@Fraccaman
Copy link
Member Author

internally we let the CDN gzip the request, thats why I switched it off

@pedrorezende pedrorezende merged commit efd9f3d into main Sep 19, 2024
10 checks passed
@pedrorezende pedrorezende deleted the fraccaman/improve-docker-images branch September 19, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrorezende pedrorezende pedrorezende approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fraccaman @pedrorezende