IBC basic form #1106
Merged
IBC basic form #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
force-pushed
the
ibc-basic-form
branch
2 times, most recently
from
5a0ca67
to
56a9cec
Compare
emccorson
requested review from
pedrorezende,
euharrison,
jurevans and
mateuszjasiuk
pedrorezende
approved these changes
Sep 17, 2024
| const [channelId, setChannelId] = useState(""); | ||
|
|
||
| const withErrorReporting = | ||
| (fn: () => Promise<void>): (() => Promise<void>) => |
There was a problem hiding this comment.
Can we make this signature more readable, or simplify this function?
There was a problem hiding this comment.
I've changed the function to use await instead of then.
emccorson
force-pushed
the
ibc-basic-form
branch
2 times, most recently
from
b59b798
to
1509c8a
Compare
emccorson
added a commit
that referenced
this pull request
Sep 18, 2024
emccorson
added a commit
that referenced
this pull request
Sep 18, 2024
This is a very rough first draft intended to be used as a starting point for building more IBC features.
emccorson
force-pushed
the
ibc-basic-form
branch
from
1509c8a
to
006a07e
Compare
This is a very rough first draft intended to be used as a starting point for building more IBC features.
emccorson
force-pushed
the
ibc-basic-form
branch
from
006a07e
to
a47e2f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a very basic form for IBC transfers into Namada. It is a rough first draft intended to be used as a base for building further IBC features and is definitely not production-quality code. It only works for transfers from the main Cosmos testnet (
theta-testnet-001).I've not used our existing
Keplrclass from the integrations package for this because I wanted to see how we need to use Keplr for IBC before building any abstractions. I was thinking I might end up refactoring the integrations in the end anyway because the existing integrations abstraction was written with the old interface in mind, which had a very different design.To test you will need gaiad and hermes set up locally. I can help anyone reviewing this PR set up what is needed.
Added
Fixed