feat: add static chains config #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszjasiuk
force-pushed
the
feat/add-static-chain-configs
branch
from
402e4f5
to
b40ea5c
Compare
mateuszjasiuk
requested review from
pedrorezende,
euharrison,
jurevans and
emccorson
pedrorezende
requested changes
Sep 13, 2024
apps/namadillo/src/registry/index.ts
Outdated
| return loadedConfigs[index]; | ||
| } | ||
|
|
||
| export function chainConfigByName(name: string): ChainConfig { |
There was a problem hiding this comment.
Can we improve name type to enforce only the available keys?
There was a problem hiding this comment.
I think we can define type like:
type ChainName = 'cosmoshub' | 'namada';
At this point I'm not sure though if we will always have every json loaded so it might be undefined anyways.
OR to be more precise at first I thought this type will grow a lot :D but now I'm not sure about this loading thing also.
WDYT?
There was a problem hiding this comment.
I think this works for now :) let's keep it in mind so we can scale it in a better way
| @@ -81,3 +84,7 @@ export const chainParametersAtom = atomWithQuery<ChainParameters>((get) => { | |||
| }, | |||
| }; | |||
| }); | |||
|
|
|||
| export const chainConfigAtom = atomFamily((chainName: string) => | |||
There was a problem hiding this comment.
Do we really need an atom for this?
mateuszjasiuk
force-pushed
the
feat/add-static-chain-configs
branch
from
b40ea5c
to
e06f9f8
Compare
mateuszjasiuk
force-pushed
the
feat/add-static-chain-configs
branch
from
956890c
to
00ae7f7
Compare
mateuszjasiuk
force-pushed
the
feat/add-static-chain-configs
branch
from
00ae7f7
to
16314fe
Compare
pedrorezende
approved these changes
Sep 19, 2024
pedrorezende
added a commit
that referenced
this pull request
Sep 19, 2024
This reverts commit dcb53aa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most basic stuff.
We can move registry to separate package also