Review fixes

- use vec![]
- don't === undefined
- use minus

apps/namada-interface/src/App/Staking/StakingOverview/AllValidatorsTable/AllValidatorsTable.tsx

@@ -89,7 +89,7 @@ const sortValidators = (sort: Sort, validators: Validator[]): Validator[] => {
       (a, b) => a.name.localeCompare(b.name) :
     sort.column === AllValidatorsColumn.VotingPower ?
       ((a, b) =>
-        a.votingPower === undefined || b.votingPower === undefined ? 0 :
+        !a.votingPower || !b.votingPower ? 0 :
         a.votingPower.isLessThan(b.votingPower) ? -1 : 1) :
     sort.column === AllValidatorsColumn.Commission ?
       ((a, b) => a.commission.isLessThan(b.commission) ? -1 : 1) :

packages/shared/lib/src/query.rs

@@ -154,11 +154,8 @@ impl Query {
     ) -> Result<JsValue, JsError> {
         let owner_addresses: Vec<Address> = owner_addresses
             .into_iter()
-            .map(|address| {
-                //TODO: Handle errors(unwrap)
-                let address_str = &(address.as_string().unwrap()[..]);
-                Address::from_str(address_str).unwrap()
-            })
+            .filter_map(|address| address.as_string())
+            .filter_map(|address| Address::from_str(&address).ok())
             .collect();
 
         let mut validators_per_address: HashMap<Address, HashSet<Address>> = HashMap::new();
@@ -173,10 +170,8 @@ impl Query {
             validators_per_address.insert(address, validators);
         }
 
-        let mut bonds: Vec<(Address, Address, String, String)> =
-          Vec::new();
-        let mut unbonds: Vec<(Address, Address, String, String, String)> =
-          Vec::new();
+        let mut bonds = vec![];
+        let mut unbonds = vec![];
 
         let epoch = namada::ledger::rpc::query_epoch(&self.client).await;
         for (owner, validators) in validators_per_address.into_iter() {