Skip to content

Commit

Permalink
Fix error on submit public key reveal, clean up logs
Browse files Browse the repository at this point in the history
  • Loading branch information
jurevans committed Jul 17, 2023
1 parent 6ce3cf3 commit 8acdfe7
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,6 @@ export const ConfirmLedgerBond: React.FC<Props> = ({

// Sign with Ledger
const signatures = await ledger.sign(bytes, path);
const { errorMessage, returnCode } = signatures;

if (returnCode !== LedgerError.NoErrors) {
setError(errorMessage);
return setStatus(Status.Failed);
}

// Submit signatures for tx
setStatusInfo("Submitting reveal pk tx...");
Expand Down
1 change: 0 additions & 1 deletion apps/extension/src/background/ledger/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,6 @@ export class LedgerService {
// TODO: We need the correct type updated in ResponseSign
} = signatures as any; // eslint-disable-line

console.log({ wrapperSig, rawSig });
if (!wrapperSig) {
throw new Error("No wrapper signature was produced!");
}
Expand Down
4 changes: 1 addition & 3 deletions packages/shared/lib/src/sdk/mod.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use crate::utils::{console_log, to_js_result};
use crate::utils::to_js_result;
use crate::{
rpc_client::HttpClient,
sdk::masp::WebShieldedUtils,
Expand Down Expand Up @@ -256,8 +256,6 @@ impl Sdk {
tx.protocol_filter();
tx.add_section(Section::Signature(wrapper_sig));

console_log(&format!("Tx: {:?}", &tx));

Ok(tx)
}

Expand Down

0 comments on commit 8acdfe7

Please sign in to comment.