fix: stop passing ActionButton props to DOM element (#938)

This was throwing a React error in the console.
anoma · Jul 23, 2024 · 7c7f118 · 7c7f118
1 parent bf07a28
commit 7c7f118
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/packages/components/src/ActionButton.tsx b/packages/components/src/ActionButton.tsx
@@ -87,16 +87,21 @@ export const ActionButton = ({
   size,
   borderRadius,
   disabled,
-  ...props
+  outlineColor,
+  textColor: textColorProp,
+  backgroundColor: backgroundColorProp,
+  backgroundHoverColor: backgroundHoverColorProp,
+  textHoverColor: textHoverColorProp,
+  as,
+  ...domProps
 }: ActionButtonProps<keyof React.ReactHTML>): JSX.Element => {
-  const outlineColor = props.outlineColor;
-  const textColor = props.textColor || outlineColor || "black";
+  const textColor = textColorProp || outlineColor || "black";
   const backgroundColor =
-    props.backgroundColor || (props.outlineColor ? "transparent" : "yellow");
+    backgroundColorProp || (outlineColor ? "transparent" : "yellow");
   const backgroundHoverColor =
-    props.backgroundHoverColor || props.outlineColor || "black";
+    backgroundHoverColorProp || outlineColor || "black";
   const textHoverColor =
-    props.textHoverColor || (props.outlineColor ? "black" : backgroundColor);
+    textHoverColorProp || (outlineColor ? "black" : backgroundColor);
 
   const outlined = !!outlineColor;
   const colorString = getDefaultColorString(backgroundColor);
@@ -107,7 +112,7 @@ export const ActionButton = ({
     outlined ? getDefaultColorString(outlineColor) : undefined;
 
   return createElement(
-    props.as ?? ("href" in props ? "a" : "button"),
+    as ?? ("href" in domProps ? "a" : "button"),
     {
       className: twMerge(
         actionButtonShape({
@@ -126,7 +131,7 @@ export const ActionButton = ({
         "--outline": outlineColorString,
       } as CSSProperties,
       disabled,
-      ...props,
+      ...domProps,
     },
     <>
       {icon && (