Skip to content

Commit

Permalink
Update types, placeholder comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jurevans committed Jul 12, 2023
1 parent 561d149 commit 5382c2e
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 7 deletions.
10 changes: 6 additions & 4 deletions apps/extension/src/background/ledger/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ export class LedgerService {
}

const {
wrapperSignature: { signature: wrapperSig },
rawSignature: { signature: rawSig },
wrapperSignature: { raw: wrapperSig },
rawSignature: { raw: rawSig },
} = signatures;

if (!wrapperSig) {
Expand All @@ -97,6 +97,7 @@ export class LedgerService {

const signedTransfer = await this.sdk.sign_tx(
fromBase64(bytes),
// TODO: Pass wrapperSig and rawSig as new Uint8Array()
toHex(wrapperSig),
toHex(rawSig)
);
Expand Down Expand Up @@ -164,8 +165,8 @@ export class LedgerService {
}

const {
wrapperSignature: { signature: wrapperSig },
rawSignature: { signature: rawSig },
wrapperSignature: { raw: wrapperSig },
rawSignature: { raw: rawSig },
} = signatures;

if (!wrapperSig) {
Expand All @@ -178,6 +179,7 @@ export class LedgerService {

const signedBond = await this.sdk.sign_tx(
fromBase64(bytes),
// TODO: Pass wrapperSig and rawSig as new Uint8Array()
toHex(wrapperSig),
toHex(rawSig)
);
Expand Down
2 changes: 2 additions & 0 deletions packages/ledger-namada/dist/processResponses.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/ledger-namada/dist/processResponses.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions packages/ledger-namada/dist/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,14 @@ export interface ResponseNullifier extends ResponseBase {
raw_nf: Buffer;
}
export interface ISignature {
raw: Buffer;
salt: Buffer;
hashes: Buffer[];
pubkey: Buffer;
signature: Buffer | null;
}
export declare class Signature implements ISignature {
raw: Buffer;
salt: Buffer;
hashes: Buffer[];
pubkey: Buffer;
Expand Down
2 changes: 2 additions & 0 deletions packages/ledger-namada/dist/types.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5382c2e

Please sign in to comment.