-
Notifications
You must be signed in to change notification settings - Fork 4
Step by step guide for beginners #1116
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1116 +/- ##
==========================================
Coverage ? 86.93%
==========================================
Files ? 85
Lines ? 4057
Branches ? 237
==========================================
Hits ? 3527
Misses ? 458
Partials ? 72 Continue to review full report at Codecov.
|
@ankit-saraf hey the doc looks good now, can you please squash the commits then I can give a final look and approve |
@vj-codes Can u please tell me how to do that |
Should i use |
@ankit-saraf yes , if you did git pull from master branch |
No, if the PR is sent from master branch then only we need to squash them in master branch. So the thing you should take care is use the branch where you were working from. You can read more this here. |
3e95ae6
to
798316c
Compare
Seems like I overwrote the changes that I did here on Github. |
BEGINNER_GUIDE.md updated BEGINNER_GUIDE.md mistakes corrected corrected file
441e0fc
to
22dbb79
Compare
@vj-codes Pls review. I squashed all the commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guides like this exist all over the internet.
My only concern with such guides: there is a very high chance that we forget something and we mislead the contributor into doing something else because we forgot about one little step.
I'd really love this to exist in sort of a meta-site, maybe documentation? But it makes no sense to be in vms
.
Description
Created BEGINNER_GUIDE.md file
Fixes #1111
Type of Change:
Checklist: