Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

feat: Allow user signup using Github #1082

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Nibba2018
Copy link

Description

Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.

Fixes #1027

Type of Change:

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

  • Click login and select sign in with Github

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Nibba2018 Nibba2018 mentioned this pull request Sep 28, 2020
5 tasks
@Nibba2018 Nibba2018 marked this pull request as ready for review September 28, 2020 16:47
@Nibba2018
Copy link
Author

Nibba2018 commented Sep 28, 2020

GitHub login process so far:
ezgif com-video-to-gif

User data printed to the terminal and stored in database(more data can be accessed):

{'username': 'Nibba2018', 'email': '[email protected]', 'fullname': 'Soham Biswas', 'first_name': 'Soham', 'last_name': 'Biswas'}

Feature not implemented: Form auto-fill.

@Kajol-Kumari

@satya7289
Copy link
Contributor

GitHub login process so far:
ezgif com-video-to-gif

User data printed to the terminal and stored in database(more data can be accessed):

{'username': 'Nibba2018', 'email': '[email protected]', 'fullname': 'Soham Biswas', 'first_name': 'Soham', 'last_name': 'Biswas'}

Feature not implemented: Form auto-fill.

@Kajol-Kumari

You can do 1 things @Nibba2018
After the user is registered via GitHub, you have to ask (prompted different forms) where the user needs to fill the additional detail requires to registered for a user.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user signup using GIthub
2 participants