Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Fix: Enhancement in scenarios UI #1427

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aditmehta9
Copy link
Member

@aditmehta9 aditmehta9 commented Apr 15, 2020

Description

Enhance the UI of Level 1 & 2 scenario of Hospital and Library scenario

Fixes #1406

Type of Change:

Delete irrelevant options.

  • Code
  • User Interface

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This update in UI has been tested in 5.0 inch mobile to 6.3 inch mobile screen size.
image
image
image
image

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings

@aditmehta9
Copy link
Member Author

@robotjellyzone @sammy1997 I am sorry for doing pull requests multiple times. It won't happen again. I mistakenly had copied the link of AnitaB while cloning that's why this problem was created. Thanks for the guidance and for bearing my mistake. It will never happen again. Now all problems are sorted.

@aditmehta9
Copy link
Member Author

As you said earlier I have even squashed the commits

Copy link
Contributor

@Mehulipal Mehulipal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of any better way to tackle this kind of issues as these type of issues seem to be present at all the levels of the game? Kindly enlighten...

@aditmehta9
Copy link
Member Author

Yes, I have updated for level 1 and level 2 scenarios. Sorry, I forgot to mention the issue #1396.

@aditmehta9
Copy link
Member Author

aditmehta9 commented Apr 15, 2020

Please look at mocks. I had included mocks of levels 1 and 2.

@aditmehta9 aditmehta9 closed this Apr 15, 2020
@aditmehta9 aditmehta9 reopened this Apr 15, 2020
@aditmehta9
Copy link
Member Author

@sammy1997 I have squashed commits please review.

@sammy1997
Copy link
Contributor

@aditmehta9 I have closed #1396 Please remove it from the PR description

@aditmehta9
Copy link
Member Author

aditmehta9 commented Apr 18, 2020

@aditmehta9 I have closed #1396 Please remove it from the PR description

Yes, Sir updated, please review whenever you are free @sammy1997 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement of Library Scene in Level 2
3 participants