Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Re: Karma points do not add if Ok is not pressed after full power #1418

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Priyansh-Kedia
Copy link
Contributor

Description

The Karma points add up even when the dialog box is cancelled.

Fixes #1414

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested on OnePlus6t

@vold-la
Copy link

vold-la commented Apr 13, 2020

@Priyansh-Kedia try increasing SessionHistory.currScenePoints also in CancelListener ,so that current point also increases :)

@Priyansh-Kedia
Copy link
Contributor Author

@Priyansh-Kedia try increasing SessionHistory.currScenePoints also in CancelListener ,so that current point also increases :)

Hello @vold-la
The thing is, the current application just adds 5 points in the total points (Session History) on click of the OK button.
As this issue was focused on solving the problem related to the OK button, I think I should only add the points to total points on cancel of the dialog box.

Also, these powers are shown to fetch points in the complete game and hence I think these points should be added to the total game points only.
What do you think?
I would be happy to open a separate issue regarding this if you think that this should be implemented as we would have to change some code for the press of OK button too which is out of the scope of this issue.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karma points do not add if Ok is not pressed after full power
3 participants