This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Github action integrated with codecov #632
feat: Github action integrated with codecov #632
Changes from all commits
d3487e5
137b2a6
d388010
4bf562c
0dc2fdf
1cd8ac7
d563a07
c860727
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand any of the changes here, and please don't remove a whole test check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you check deeply then you come to know that these are test cases for
RequestMeetupFormTestCase
notAddMeetupFormTestCase
that's why I am adding theRequestMeetupForm
instead ofAddMeetupForm
Actually whole test cases are wrong..Also, Here this line
self.assertRaises(ValidationError, form.clean_time())
is not needed because in the clean_time method time is used for return ValidationError(however, here time is None because on adding requestmeetup due to clean_time method time will be None). You can check these phenomenon by printing form.clean().There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for diving deep into this! Can you please open an issue about this?