End date and time added to forms and displayed #452
Conversation
| @@ -3,10 +3,16 @@ | |||
| {% block meetup_location_page_content %} | |||
| <h2 id="meetup-title">{{ meetup.title }}</h2> | |||
| <div class="box-container box-body pt25"> | |||
| <p> | |||
There was a problem hiding this comment.
changes like these shouldn't be reflected.
| {% if meetup.end_date %} | ||
| <b> - </b> {{ meetup.end_date }} | ||
| {% endif %} | ||
| |
There was a problem hiding this comment.
have you checked whether the responsiveness is getting affected by this or not ?
There was a problem hiding this comment.
@abhi20161997 Responsiveness is not affected works fine for all devices.
| @@ -27,7 +33,7 @@ <h2 id="meetup-title">{{ meetup.title }}</h2> | |||
| <td>{{ not_coming_no }}</td> | |||
| </tr> | |||
| </tbody> | |||
| </table> | |||
| </table> | |||
There was a problem hiding this comment.
again this shouldn't be reflected.
|
@Tlazypanda Also mocks should be included like before scenario and after scenario- include mocks for how the forms looked before as well. |
Tlazypanda
force-pushed
the
enddateandtime
branch
3 times, most recently
from
b99631b
to
b6cf5f2
Compare
Tlazypanda
force-pushed
the
enddateandtime
branch
from
b6cf5f2
to
6dd34f7
Compare
|
@Tlazypanda Please resolve the merge conflicts and update your codebase. This is a stale PR. Also, if possible add some tests!! The coverage seems to have decreased |
|
@Tlazypanda Please let me know if you will be working on this. Or else, I can close the PR and make the issue available for others |
|
@abhi20161997 @sakshi1499 should we close this? I had tagged the contributor but didn't get a response |
|
@sammy1997 I think we should. |
|
@sammy1997 , Yes ! It should be closed. |
Description
End date and time attributes kept optional and added to the form.After creation of meetup these attributes are displayed in meetup.html.
MOCKS
Before-
After-
Fixes #432 #286
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Tested locally screenshots attached..
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only