Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue #573 Error message for field 'name' not filled #1160

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

umichritikashetty
Copy link

Description

Fixes #573

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This was tested by inputting different strings (characters, empty strings, or strings with just spaces) in the name field and ensuring that the error message is always listed under the 400 section of error messages.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • [x ] My changes generate no new warnings
  • [X ] New and existing unit tests pass locally with my changes

@welcome
Copy link

welcome bot commented Dec 5, 2022

Hello there!👋 Welcome to the project!💖
Thank you and congrats 🎉 for opening your first PR on this project.✨
Please ensure your Pull Request meets the Commit Message Style Guide.
We will review it soon! Until then you can check out the README.md for more details on it.

AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct.

Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities.
Hope you have a great time here :)

@umichritikashetty umichritikashetty marked this pull request as draft December 5, 2022 20:33
@umichritikashetty umichritikashetty marked this pull request as ready for review December 11, 2022 21:04
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! your env variables are also pushed in the PR, can you please remove them, not needed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message for field 'name' is not filled
2 participants